Giter Site home page Giter Site logo

Comments (6)

talex5 avatar talex5 commented on July 21, 2024

This might be easier:

If a package's opam file contains an explicit constraint on the version of OCaml then:

  • Exclude it from non-matching versions
  • Force it to be included for matching versions (complain if not)

from ocaml-ci.

craigfe avatar craigfe commented on July 21, 2024

If a package's opam file contains an explicit constraint on the version of OCaml then:

* Exclude it from non-matching versions

* Force it to be included for matching versions (complain if not)

I'm not sure I like the idea of adding artificial constraints in .opam files purely to signal intention to the CI – it's not easy to check when / if it's possible to relax those constraints – but it's definitely easier to implement and clearly better than the prior approach of replicating this info in config files. I'd be happy with this as a solution πŸ™‚

from ocaml-ci.

dra27 avatar dra27 commented on July 21, 2024

Given the potential for stopping testing a version without realising it, might it be an idea to be stronger and actually require a version constraint on ocaml?

from ocaml-ci.

dra27 avatar dra27 commented on July 21, 2024

So if you have no constraint on OCaml, then your package should be testing on all supported versions, and either the lint or analyse phases will fail if packages aren’t installable in a given version

from ocaml-ci.

talex5 avatar talex5 commented on July 21, 2024

Given the potential for stopping testing a version without realising it, might it be an idea to be stronger and actually require a version constraint on ocaml?

Yes, I've been wondering about that too.

My only concern is that sometimes a package is temporarily uninstallable on a new compiler release due to missing dependencies (e.g. Lwt not available on OCaml 4.12). We don't want to encourage people to go around adding ocaml < 4.12 constraints everywhere while that's being fixed.

But for lower bounds at least it seems fine. So if I say ocaml >= 4.02 then it must work with 4.02.

from ocaml-ci.

avsm avatar avsm commented on July 21, 2024

This is also an issue for Lwt now, since lwt_ppx is 4.04 only, but the rest of the opam packages should build on 4.02 but aren't being tested.

from ocaml-ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.