[Enhancement suggestion] allow to add addition get parameter like sap-client

[p-mathias]

[Enhancement suggestion] allow to add addition get parameter like sap-client

[texttechne]

Hi @p-mathias,
query params belong to the responsibility of the used HTTP client.
I would imagine that you're using the JqueryHttpClient as it is about SAP.

For axios and fetch there are options readily available which can be set on a global level when intializing the HTTP client.
Axios example:

new AxiosHttpClient({params: {"sap-client": "200"})

I'm astonished to see that it's not that easy regarding jQuery. It looks like you can use the prefilter option for that use case. Then along these lines:

$.ajaxPrefilter(function( options ) {
    options.url = options.url + "?sap-client=200";
  }
});

Probably you would need to do a bit more logic here => when querying, then you need to check if the "?" becomes a "&"...

I'll ponder a bit, if this can be easily built-into the jqueryHttpClient.

If you have any suggestions regarding improvements of the docs in this respect...

[p-mathias]

Well jquery is fare away from being in scope for me,
atm i try my luck with fetch api,
but doesn't got working solution done.

[texttechne]

Hi p-mathias,
ah ok, so this is also missing in the fetch client.
I'll add this option to both clients then as constructor param (see Axios example).

[texttechne]

Hi @p-mathias,

I've added appropriate options for the fetch and jquery http client.
For fetch it would like:

new FetchClient({params: {"sap-client": "200"}}); // actually doesn't matter if you use "200" or 200 as number

Released with @odata2ts/http-client-fetch version 0.5.0.

Please try it out and close this issue if it works.

[p-mathias]

okay i will do it
mention repo: https://github.com/odata2ts/http-client

[p-mathias]

0.5 doesn't got released so i can't test this: https://www.npmjs.com/package/@odata2ts/http-client-fetch

[texttechne]

WTF?! You're right, I've just released those versions.
Sorry for the inconvenience...

[p-mathias]

works fine