Giter Site home page Giter Site logo

Comments (4)

kohr-h avatar kohr-h commented on September 24, 2024

Why an extra package? The function is trivial to extend to multiple factors, arbitrary dimension and custom reductions. And the rebin implementation is not faster.

from odlworkshop.

adler-j avatar adler-j commented on September 24, 2024

Well the function is non-trivial to extend to non-integer reductions for example.

Overall we don't want to teach people to write their own code. Use a library if there is one.

from odlworkshop.

kohr-h avatar kohr-h commented on September 24, 2024

Well the function is non-trivial to extend to non-integer reductions for example.

Which is not supported by rebin either.

Overall we don't want to teach people to write their own code. Use a library if there is one.

Agree in general, but if the code consists of two lines, then I prefer that over a package that has to be installed. I also find it kind of instructive to see how do do summing over blocks efficiently in Numpy. With an external package, it's all magic.

from odlworkshop.

adler-j avatar adler-j commented on September 24, 2024

Which is not supported by rebin either.

Seems you're right

Agree in general, but if the code consists of two lines, then I prefer that over a package that has to be installed. I also find it kind of instructive to see how do do summing over blocks efficiently in Numpy. With an external package, it's all magic.

Well to 98% of the people who need a tutorial, that line is also magic. At least from rebin.rebin they can figure out what it is supposed to do or google the docs. If we're keeping it I'd at least suggest adding a link to e.g. this SO answer:

https://stackoverflow.com/questions/4624112/grouping-2d-numpy-array-in-average/4624923#4624923

from odlworkshop.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.