Giter Site home page Giter Site logo

Comments (9)

 avatar commented on May 11, 2024

/Font-Awesome/icons/ i tried slack ( fa-slack ) and is not rendered

from odoo.

parthivgls avatar parthivgls commented on May 11, 2024

There are couple of things with odoo for FontAwesome I have discovered a
day back.
1st is there is a list of icons that has been hardcoded in JS.
https://github.com/odoo/odoo/blob/8.0/addons/website/static/src/js/website.editor.js#L1676

2ndly, FontAwsome version that odoo is using is 4.0.3 where latest is 4.2
available.

So you have to first update FontAwsome available in odoo and change
hardcode code for new icons.

On Sun, Sep 7, 2014 at 6:13 PM, Patrick Schanen [email protected]
wrote:

/Font-Awesome/icons/ i tried slack ( fa-slack ) and is not rendered


Reply to this email directly or view it on GitHub
#191 (comment).

Thanks & Regards,
Parthiv Patel

from odoo.

 avatar commented on May 11, 2024

Thanks for the answer. I use actualy the hosted Odoo on www.business-solutions.lu https://business-solutions.odoo.com

from odoo.

smack815 avatar smack815 commented on May 11, 2024

@patrickschanen @josemoralesp @parthivgls, FontAwesome has just recently been updated to 4.2 from 4.0.3 with pull request #2104. Hope this helps.

from odoo.

parthivgls avatar parthivgls commented on May 11, 2024

@smack815 Thank you for pointing out.

As I can see #2104 added 4.1 but it's still fine, but why hardcoded icons list ?? couldn't it be more flexible that if odoo don't want to add new icons, some one using a modular approach can still write his own module to support new version !!!

from odoo.

smack815 avatar smack815 commented on May 11, 2024

@parthivgls If you read all of #2104, I convinced them to go with 4.2 for the upgrade.

The hard coding might be some old code that needs to be updated/rethought. You probably should make your comment directly to odoo in #2104.

from odoo.

xmo-odoo avatar xmo-odoo commented on May 11, 2024

As I can see #2104 added 4.1 but it's still fine, but why hardcoded icons list ??

How else would the editor know which icons are available, so that it could list them in the icon picker?

couldn't it be more flexible that if odoo don't want to add new icons, some one using a modular approach can still write his own module to support new version !!!

There's nothing preventing you from adding new icons to the list, just append them to website.editor.FontIconsDialog.icons.

from odoo.

sle-odoo avatar sle-odoo commented on May 11, 2024

Hello,
I'm closing this as it is an implementation detail, as @xmo-odoo pointed out.
Regards

from odoo.

krocket avatar krocket commented on May 11, 2024

@parthivgls
Hi,
A small module https://github.com/krocket/website_font_awesome_4_3_0
regards.

from odoo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.