Comments (17)
I would differ between programming test and system validation tests. For me there are three kinds of test:
1.) The normal nose test should be very fast because you execute them quite often to check if the program itself works. The optimisation itself should not be part of these tests.
2.) Validation test to check if an optimisation still gets the same results after changing the code. These test should be done before a merge or at least before we will release. There should be a handful of representative models.
3.) Plausibility test to check the results of a new optimisation. They are optional but a good help if the models become more and more complicated.
I think your suggestions are of the third kind.
from oemof-solph.
Maybe it is to much for the restructuring meeting but we should adopt a roadmap there. Shall we change the milestone to that meeting?
from oemof-solph.
perhaps it would be better suited for the oemof developer meeting in may. what do you think?
from oemof-solph.
It is an important part of the quality management and people already broke other peoples app by pushing untested code. But it will be a matter of time, so let's see.
from oemof-solph.
I would shift that topic to the re-factoring meeting.
from oemof-solph.
@ckaldemeyer Do you think this is issue is covered by PR #160 and #154? Otherwise you should specify the remaining topics.
from oemof-solph.
@ckaldemeyer : Sorry I misunderstood the main point. I guess the main point is to implement plausibility tests. Do you think it should be a part of solph or a part of the outputlib?
from oemof-solph.
Sorry, just hit the wrong button
from oemof-solph.
@ckaldemeyer : Sorry I misunderstood the main point. I guess the main point is to implement plausibility tests. Do you think it should be a part of solph or a part of the outputlib?
Another idea: would a method in the EnergySystem class make sense?
If not, I would tend to do it in solph!
from oemof-solph.
I think it depends on your approach but if it is part of the EnergySystem it should work for oemof in general. So think implementing it within solph will be easier.
from oemof-solph.
I think it depends on your approach but if it is part of the EnergySystem it should work for oemof in general. So think implementing it within solph will be easier.
from oemof-solph.
Maybe we can shedule this to the release after the refactoring-release as I won't be able to commit myself before September..
from oemof-solph.
I guess this can be closed, or not?
from oemof-solph.
Or at least be split in two kinds of tests
from oemof-solph.
I gues this can be closed, or not?
from oemof-solph.
We do have code tests, example test.
We do not have plausibility tests and as I understand it this was your main concern according to your first comment.
The ideas of you first comment are quite interesting. Maybe we should add wiki to save these ideas but make it possible to close ancient issues.
https://github.com/oemof/oemof/wiki/ideas
from oemof-solph.
@oemof/oemof-developer-group Please keep it in mind that there is a wiki like this.
from oemof-solph.
Related Issues (20)
- GenericStorage is missing `custom_attributes` attribute HOT 7
- Busses should have the attribute carrier HOT 1
- Add an example for the OffsetTransformer with two series of coefficients HOT 1
- Error in Generic Invest in oemof v05 HOT 2
- Examples are untested HOT 2
- ModuleNotFoundError when running `oemof_installation_test`
- Assert fix Flow values are > min
- Add SCIP solver to open source solver HOT 5
- CBC (and other AMPL solvers) are not linked correctly anymore HOT 6
- Activate custom_attributes HOT 1
- oemof_installation_test not working after update to 0.5 HOT 1
- Bump pyomo version in requirements? HOT 4
- Multi-period feature could be simplified HOT 1
- Link API reference in component description HOT 2
- Accept negative Flows for GenericStorage HOT 2
- Readthedocs build not recent HOT 2
- SinkDSM load shedding limit needs rework
- Test length of sequences/parameters when creating the model
- Fixed costs for investments in SinkDSM are erroneous (multi-period) HOT 1
- v0.5 not named in chanelog HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oemof-solph.