Giter Site home page Giter Site logo

Comments (7)

oerdnj avatar oerdnj commented on July 30, 2024

Or just leave the -e;

I have already noticed this and fix is on it's way...

from deb.sury.org.

BahnhofMS avatar BahnhofMS commented on July 30, 2024

If -e is left out it will break on bash instead, causing read to only process the first entry in "$SAPIS"

from deb.sury.org.

oerdnj avatar oerdnj commented on July 30, 2024

The default shell in Debian and Ubuntu is dash. Is there a way how to reproduce it in real life deployment?

from deb.sury.org.

BahnhofMS avatar BahnhofMS commented on July 30, 2024

Fair point, but since the default is still a configuration option that can be changed, we should probably aim to keep "#!/bin/sh"-scripts portable.

We should use:
printf "%b\n" "$SAPIS" | \
...according to https://wiki.ubuntu.com/DashAsBinSh#echo
and http://www.unix.com/man-page/POSIX/1posix/echo/

from deb.sury.org.

oerdnj avatar oerdnj commented on July 30, 2024

Thanks for the tip, I have modified the script and it will included in next upload to the PPAs (and Debian)...

SAPIS="apache2:apache2\napache2filter:apache2\ncgi:php5\nfpm:php5-fpm\n"
[...]
printf "$SAPIS" | \

from deb.sury.org.

BahnhofMS avatar BahnhofMS commented on July 30, 2024

(Np, I should be thanging you for the work maintaining this. ^_^ Donation is on my todo, btw).
Personally I wouldn't skip "%b\n" and risk silently ignore the last tuple because of a missing final \n. But either way is ok.

from deb.sury.org.

oerdnj avatar oerdnj commented on July 30, 2024

Re: "%b\n"

I plan to rewrite that little bit more... see my discussion with Steve here: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1356113

P.S.: I now have a bitcoin address too :)

from deb.sury.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.