Giter Site home page Giter Site logo

Comments (6)

SamBrishes avatar SamBrishes commented on June 10, 2024 2

Hello,

thanks for reporting this issue. I fixed both, the PHP error and the documentation link. Available in the next branch, will be released with v3.2.2.

Sincerely,
Sam.

from oc-mall-plugin.

tobias-kuendig avatar tobias-kuendig commented on June 10, 2024 2

This fix will be released in v3.2.2.

from oc-mall-plugin.

SamBrishes avatar SamBrishes commented on June 10, 2024 1

You can overwrite the partial within your theme and remove the oldPrice part in the mentioned file.

{% set price = price|default(item.price()) %}

{% if price.official or item.oldPrice() %}
    <div class="mall-product__old-price">
        {% if price.official %}
            {{ price.official.string|raw }}
        {% else %}
            {# item.oldPrice().string|raw #}
        {% endif %}
    </div>
{% endif %}
<div class="mall-product__current-price">
    {% partial __SELF__ ~ '::currentprice' price=price.string %}
</div>

from oc-mall-plugin.

SamBrishes avatar SamBrishes commented on June 10, 2024 1

Fixed in next branch, released in v3.3.1.

from oc-mall-plugin.

magenizr avatar magenizr commented on June 10, 2024

In our case, we had no records under Settings > Price Categories simply because we started with a fresh installation. A temporary fix until 3.2.2 is release is:

  • Create new record under Settings > Price Categories
  • Make sure code is set to old_price ( not old-price )
  • Keep it enabled as suggested by @dathwa

from oc-mall-plugin.

dathwa avatar dathwa commented on June 10, 2024

Hello @tobias-kuendig .
Mall 3.3.0. After disabling "Old Price", I'm seeing this error on front end...
development.ERROR: Twig\Error\RuntimeError: Impossible to access an attribute ("integer") on a null variable in "\plugins/offline/mall/components/product/price.htm" at line 3. in \vendor\twig\twig\src\Extension\CoreExtension.php:1510

This happens when CMS_STRICT_VARIABLES=true

Thanks

from oc-mall-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.