Uploading from Windows, cannot judge zip extension?

[offline-gmbh]

Uploading from Windows, cannot judge zip extension?

[tobias-kuendig]

Thank you! This change should fix the issue:

c09a662

You can apply it manually or use the latest release to update.

[tobias-kuendig]

Do you upload from Windows to Ubuntu (Server) or from Ubuntu to Windows (Server)?

It should not matter from what OS you are uploading the file. It can make a difference on the server though.

If you add a dd($file->clientExtension()); or dd($file); before this line what output do you get when you upload your file?

[nikukyugamer]

@tobias-kuendig

thank you for quick response! and sorry for lack of descripiton.
my environment is below.

• Server OS is Linux (Ubuntu 16.04 LTS)
• Client OS is Windows 7 and Linux (Ubuntu 16.04 LTS)
• Client web browser is Chrome and Firefox
  • On Windows, unavailable by both browsers
  • On Linux, available by both browsers

certainly I also guess OS doesn't matter. I try test codes you show as soon as possible.

please wait a little 😃

[nikukyugamer]

sorry for late response.

I tried your idea. so it looked file was upload correctly and app doesn't show dump and doesn't die (Upload successful is displayed but not uploaded in fact).

environment:

• OS
  • Windows 7
  • Ubuntu
• Web browser
  • Chrome
  • Firefox
• file extension
  • zip
  • not zip

I tried all combinations. result is the same.

I doubt php.ini settings...

[tobias-kuendig]

Yes, that's because it's an AJAX request. The dump will only be visible in the developer tools in the Network tab. Look there.

Alternatively you can add a info statement and then look in your log files for the output.

info('Uploading file', ['file' => $file, 'extension' => $file->clientExtension()]);

[nikukyugamer]

oh, thanks! soon i tried again. below is log by info.

Windows 7, Chrome and zip extension file

[2017-10-19 07:13:27] production.INFO: Uploading file {"file":"[object] (Illuminate\\Http\\UploadedFile: /tmp/phpYyl9wn)","extension":null} 

Windows 7, Chrome and txt extension file

[2017-10-19 07:19:09] production.INFO: Uploading file {"file":"[object] (Illuminate\\Http\\UploadedFile: /tmp/phpaiXIU5)","extension":"txt"} 

Ubuntu 16.04 LTS, Chrome and zip extension file

[2017-10-19 07:17:20] production.INFO: Uploading file {"file":"[object] (Illuminate\\Http\\UploadedFile: /tmp/phpzq55cC)","extension":"zip"} 

Ubuntu 16.04 LTS, Chrome and txt extension file

[2017-10-19 07:28:58] production.INFO: Uploading file {"file":"[object] (Illuminate\\Http\\UploadedFile: /tmp/phpxyT9m2)","extension":"txt"} 

in Firefox, the same result.

[tobias-kuendig]

Could you replace the info statement with the following and provide me with the log entry when you upload the zip file on Windows again?

info('Uploading file', ['mime' => $file-> getMimeType(), 'extension' => $file->getExtension(), 'guessed' => $file->guessExtension()]);

[nikukyugamer]

I replaced the statement.

[2017-10-19 08:26:41] production.INFO: Uploading file {"mime":"text/plain","extension":"","guessed":"txt"} 
[2017-10-19 08:26:49] production.INFO: Uploading file {"mime":"application/zip","extension":"","guessed":"zip"} 

the former file is txt extension. the latter is zip extension.

[nikukyugamer]

@tobias-kuendig

Great. I confirmed extracting zip correctly on not only Ubuntu but also Windows!

thank you for this awesome product. I'm glad to contribute. 😄