Comments (7)
Hmm, I take it back, the cdm v5 ddl in the repo does use integer consistently but in our own environment we apply it as bigint. So, perhaps this issue should be to convert integer to bigint for mssql DDL.
from commondatamodel.
@chrisknoll is this still an issue?
from commondatamodel.
Yes and No. See here:
https://github.com/OHDSI/CommonDataModel/blob/master/Sql%20Server/OMOP%20CDM%20ddl%20-%20SQL%20Server.sql#L227
Originally, I thought i found cases where person_id was a bigint in the default DDL but I must have been looking at our internal CDM schema and not the raw DDL on the CDM repo.
The 'No' part is that the CDM schema DDL on the repo is consistent: all person_ids are declared as Integer.
The 'Yes' part is that the sources that we ETL commonly have values for person ID that exceed the limits of an integer, and therefore bigint might be more appropriate. That's the root of the issue I reported here. I'll update the title to reflect this.
@cgreich , could you chime in on this, is this the sort of thing that should be a WG change or is this something we can leave as int and let third parties make a one-off change to their CDMs if an integer is not large enough to store a person_id?
from commondatamodel.
what is the boundary for int - big int? Is the boundary the same for all db engines? Change to bigint in canonical specs would be a CDM change to discuss in the CDM WG (in my view)
from commondatamodel.
yes, bigint is same across databases: 64bit number, vs int which is 32bit.
from commondatamodel.
Not sure what to say. We have been not being specific about this and leave it to the ETLers. Why do you think it is necessary to standardized this? Is there a consequence of some folks have it as INT?
from commondatamodel.
Nope. If left to their own ETL process, it can be handled that way.
from commondatamodel.
Related Issues (20)
- missspelling in postgres dll and inidices HOT 2
- building contraints error missing concept_id in table concept HOT 6
- The relationship ‘Maps to value’ returns concepts that are NOT Meas Value
- OMOP Documentation suggestion for source_to_concept_map HOT 4
- Error in installation of R package
- Why is Person.brith_datetime "highly encouraged"? HOT 2
- validated_survey_sourve_value should be varchar(100)
- Add DDL for Stem table. HOT 1
- ETL conventions documentation for Person table HOT 1
- CDM 5.4 - consequences of changing int to bigint data type for primary key column ? HOT 2
- DBeaver Vocabulary Upload Issue - Multiple Failed Batch Inserts (concept.csv) HOT 2
- Error in Readme
- Proposal: rename offset column to something that is not a SQL reserved word HOT 2
- Change R package maintainer to Adam Black HOT 3
- Do a landscape assessment of the tables to determine if general conventions of the model are followed
- Add documentation for requiring records in condition_era and drug_era
- CDM Reference Materials (Table/Column Definitions & Concept Constraint List) Missing from site. HOT 2
- ERD image is not correct. concept_synonym table only has three rows. not 7 as ERD digram suggests HOT 2
- Is there any demo or test data for CDM 5.4? HOT 1
- Extending length of varchar fields in CDM and its effects on other OHDSI tools HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from commondatamodel.