Giter Site home page Giter Site logo

Comments (3)

msuchard avatar msuchard commented on August 22, 2024

Hi @egillax -- fantastic find!!! I agree that for some models we do not need to check for uniqueness. Can we add an extra boolean argument to the function to short-cut the find? In the patch, make sure to not to change the R API.

from cyclops.

egillax avatar egillax commented on August 22, 2024

Hi @msuchard ,

I did dive into this a bit more. This only seems to affect the running time when models have low N (~ 1000) and high P (~ 30k). When I tested this on data with higher N I couldn't observe any speedup by skipping the uniqueness check, I assume because the model fitting itself takes bulk of the time.

I'm not sure if you want to optimize for the case of low N - which is very quick anyway - at the cost of more complexity to the code. If you do I can submit a PR. Otherwise we can close this issue.

from cyclops.

egillax avatar egillax commented on August 22, 2024

I'm closing this. I don't think this will be useful for the type of data we normally use.

from cyclops.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.