TypeError: no implicit conversion of Agoo::ErrorStream into String

[ohler55]

TypeError: no implicit conversion of Agoo::ErrorStream into String

[ohler55]

That actually brings up two issue. The Rack spec say the error stream should be on env["rack.errors"] unless my reading of the spec is way off. That might be okay if the value of the RACK_ERRORS is "rack.errors". Is it?

Second, the spec says the only methods needed on the error stream are puts, write, flush, and close. From you description it sounds like the Rack logger expects a to_s also. What does the rack logger normally return? Anything other than something like #<Foo:0x00007ff59d801e80>?

[tomas]

Don't know. Rack::Logger simply calls Logger.new(env[RACK_ERRORS]). Shouldn't the Ruby Logger class detect that the passed object isn't a file but a stream?

[ohler55]

You would think so. I'll add a to_s that looks like the standard Ruby to_s and maybe you can see if things work.

[tomas]

I think I found the what's going on:

  class LogDevice
    def set_dev(log)
      if log.respond_to?(:write) and log.respond_to?(:close)
        @dev = log
      else
        @dev = open_logfile(log)
        @dev.sync = true
        @filename = log
      end
    end
  end

Your ErrorStream class is missing a #close method, apparently.

[ohler55]

I'll have that fixed tonight. Thanks.

[ohler55]

Had a slow moment so made the fix. It is in the close branch if you would like to try it.

[ohler55]

Does this work for you?

[tomas]

Indeed it does. Thanks @ohler55!