Attack animation and weapon can remain on-screen during victory

[ohrrpgce]

Attack animation and weapon can remain on-screen during victory

[ohrrpgce-bugbot]

Comment author: @pkmnfrk

Well, I think someone should get in there and clean it up! I might even do it,
if I'm feeling optimistic...

[ohrrpgce-bugbot]

Comment author: @rversteegen

It would be very simple to fix this by putting an 'IF vdance = 0' check around
the weapon and attack graphic drawing routine (attack graphics can remain
onscreen too).

However, sometimes the hero stops halfway through an attack animation, obvious
when dashing into a dying enemy and doing a victory dance on the other side of
the screen. Clearly attacks are being allowed if the last enemy is dying. This
is also the cause of bug bz#3 (#1016) / 38.

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

This one is a little more complicated than just the weapon display thing. It can also affect hero position and animation frame, depending on the nature of the attack being used when battle ends.

This is apparently rather easy to reproduce using the Friar's heall spell in Vikings of Midgard, according to this thread: http://castleparadox.com/ohr/viewtopic.php?t=5468&postdays=0&postorder=asc&start=15

[ohrrpgce-bugbot]

Comment author: @arperry

That bug was about the attack picture, not the weapon picture.

[ohrrpgce-bugbot]

Comment author: @bob-the-hamster

That bug was about the attack picture, not the weapon picture.

I believe it is the same bug. The only difference is the details of the particular attack, and the timing.