Add CI to check pull-requests

[leportella]

Add CI to check pull-requests

[amadeu01]

Could it be Travis CI? Or, do you want any specific CI ?

[cuducos]

Nothing specific at this moment ; )

[amadeu01]

Okay.

[amadeu01]

Hi again.

I did one really simple Travis.

Build

Which I simply run the tests as it was described on the readme. However, it raises

==================================== ERRORS ====================================
_______________ ERROR collecting candidates/tests/test_views.py ________________
ImportError while importing test module '/code/candidates/tests/test_views.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
candidates/tests/test_views.py:6: in <module>
    from candidates.models import Candidates
E   ModuleNotFoundError: No module named 'candidates.models'
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 0.21 seconds ============================

I wonder if you could give me a hand on this.

[amadeu01]

To be clear, I just run:
docker-compose run --rm api pytest

[cuducos]

Many thanks, @amadeu01 – it looks like you've catch some lines that weren't updated after last change in the architecture. I've changed two lines and now tests are passing:

diff --git a/api/candidates/tests/test_views.py b/api/candidates/tests/test_views.py
index d44b26e..ee25b77 100644
--- a/api/candidates/tests/test_views.py
+++ b/api/candidates/tests/test_views.py
@@ -3,7 +3,7 @@ import json
 import pytest
 from mongoengine.errors import NotUniqueError
 
-from candidates.models import Candidates
+from models import Candidates
 
 
 @pytest.fixture
diff --git a/api/candidates/views.py b/api/candidates/views.py
index a58fd4d..9acc84d 100644
--- a/api/candidates/views.py
+++ b/api/candidates/views.py
@@ -4,7 +4,7 @@ from restless.dj import DjangoResource
 from restless.preparers import FieldsPreparer
 from restless.serializers import JSONSerializer
 
-from .models import Candidates
+from models.candidates import Candidates
 
 
 class CandidateResource(DjangoResource):

[amadeu01]

Okay, I’ll keep on the travis script.

[cuducos]

Okay, I’ll keep on the travis script.

I would suggest you to incorporate these fixes in your PR. They are important to make sure the Travis CI is working as expected ; )

[amadeu01]

Okay! No problem, thanks!

…

Sent from my iPhone

On 23 Jul 2018, at 15:57, Eduardo Cuducos ***@***.***> wrote: Okay, I’ll keep on the travis script. I would suggest you to incorporate these fixes in your PR. They are important to make sure the Travis CI is working as expected ; ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[amadeu01]

@cuducos don’t you think that would be better to make those fixes on another PR?

[cuducos]

I think either way would be just fine.

[cuducos]

Working ; )