Giter Site home page Giter Site logo

Comments (4)

Daniel-Houston avatar Daniel-Houston commented on June 16, 2024

Anyone have any comment on this?

from okta-auth-js.

Daniel-Houston avatar Daniel-Houston commented on June 16, 2024

@jmelberg-okta Sorry to pester you, but to me this issue seems more pressing than my other issue, since the id token signature is never validated. Do you have any thoughts on this one?

from okta-auth-js.

jmelberg-okta avatar jmelberg-okta commented on June 16, 2024

I'm not sure of the historical reason as to why we're ignoring signature validation when receiving the idToken from the /token endpoint. IMO we should be defaulting this to false to ensure it gets validated.

Our team is auditing this library + making changes to ensure we have all the necessary ID Token Validation steps.

Secondly, calling token.verifyIdToken() does validate the signature by retrieving the JWKS. You can see how it is implemented here. If you're using this for Implicit flows, please use that method instead of relying on the default behavior.

I'd be happy to take a look at a PR with these changes if you have time. Please make sure to review/sign our CLA beforehand.

Thanks!

from okta-auth-js.

jmelberg-okta avatar jmelberg-okta commented on June 16, 2024

Resolved with 2.0.0.

from okta-auth-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.