Don't swallow journal serialization errors.

[okumin]

Don't swallow journal serialization errors.

[lbialy]

Do you think serialization error should fail wrapping future?

[ds300]

What I think should happen is that the cause stack trace should be logged to stderr and the resulting SQL should not be executed.

[okumin]

I think that it fails……

[lbialy]

Apparently reference implementation for LevelDB catches serialization exceptions in Try monad but doesnt perform collect { Success() } on resulting collection of Trys.

[okumin]

Such a error should be notified to PersistentActor since journals don't work if some of them silently fails.

[okumin]

I remember that serialization errors can be rejected.
http://doc.akka.io/docs/akka/2.4/scala/persistence.html#Journal_plugin_API

I'm thinking to apply the following patches.

• Not executing when all the payload cannot be serialized
• Logging when a serialization error occurs
  • This is for convenience
  • Users who want to handle such an error can use onPersistRejected.

[lbialy]

👍

[okumin]

I close this issue since it looks that the above solution is accepted.

The patch has been already applied.
2c449c5

Thanks.