Unchecked json.Unmarshal results in Blank Keys

[kylebrandt]

Unchecked json.Unmarshal results in Blank Keys

[olivere]

Can you send me your query and the results? Set Pretty(true).Debug(true) in the SearchService and paste the output (like here)?

[kylebrandt]

Query:

{"aggregations":{"g_TargetUserName":{"aggregations":{"g_eventlog_id":{"aggregations":{"ts":{"date_histogram":{"field":"@timestamp","interval":"1m"}}},"terms":{"field":"TargetUserName"}}},"terms":{"field":"eventlog_id"}}},"query":{"range":{"@timestamp":{"from":"2015-01-08T15:54:50.750119001Z","include_lower":true,"include_upper":true,"to":"2015-01-08T16:04:50.750119001Z"}}}}

(Also side bug, Query output in debug doesn't pretty format (although I care more about having access to the rawquery in code anyways).

Head of Response, note the Keys are Ints of some sort (not quoted).

  "aggregations" : {
    "g_TargetUserName" : {
      "doc_count_error_upper_bound" : 2,
      "sum_other_doc_count" : 2487,
      "buckets" : [ {
        "key" : 5447,
        "doc_count" : 2448,
        "g_eventlog_id" : {
          "doc_count_error_upper_bound" : 0,
          "sum_other_doc_count" : 0,
          "buckets" : [ ]
        }
      }, {
        "key" : 16,
        "doc_count" : 984,
        "g_eventlog_id" : {
          "doc_count_error_upper_bound" : 0,
          "sum_other_doc_count" : 0,
          "buckets" : [ ]
        }
      }, {
        "key" : 4624,
        "doc_count" : 829,
        "g_eventlog_id" : {
          "doc_count_error_upper_bound" : 0,
          "sum_other_doc_count" : 141,
          "buckets" : [ {
            "key" : "system",
            "doc_count" : 194,
            "ts" : {
              "buckets" : [ {
                "key_as_string" : "2015-01-08T15:54:00.000Z",

[olivere]

Can you update and try again? Should be fixed with this commit. Reopen if necessary.

[kylebrandt]

I don't think this is going to be correct, since the key can be a number or a string (possibly other things)...

[olivere]

And in the tests, the key is indeed a string for e.g. the "users" aggregation.

[kylebrandt]

So probably an interface, and then the user has to type switch I imagine? I had another idea but can't remember now...

[olivere]

We could to that as well. And you're right in that it's better because Keys can be of any type, not only strings and numbers.

However, remember that you'll then get a float64 when decoding the "Key" in your example. A type switch is not enough.

[olivere]

Maybe we could have the best of both worlds with this.

type AggregationBucketKeyItem struct {
    Aggregations

    Key       interface{}
    KeyNumber json.Number
    DocCount  int64
}

You could use Key to get to the interface{} while still having KeyNumber for convenience.

if bucket.Key != float64(0) {
    t.Errorf("expected %v; got: %v", float64(0), bucket.Key)
}
if got, err := bucket.KeyNumber.Int64(); err != nil {
    t.Errorf("expected %d; got: %v", 0, bucket.Key)
} else if got != 0 {
    t.Errorf("expected %d; got: %d", 0, got)
}
if bucket.KeyNumber != "0" {
    t.Errorf("expected %q; got: %q", "0", bucket.KeyNumber)
}

[olivere]

See this test for example usage.

Hope this is going to fix it.

Thanks for reporting.