[question] Is is removing both - React.PropTypes and PropTypes?

[oliviertassinari]

[question] Is is removing both - React.PropTypes and PropTypes?

[oliviertassinari]

Is it removing both versions of PropTypes?

What are the two versions?

From what I understand its also working by default for whole node_modules.

It' working on your whole Babel setup. If you let babel traverse the node_modules, this plugin will too. Noticed that most people only let babel traverse their source code.

what exactly is stopping this transform to work?

I don't understand, nothing is supposed to stop that transform to work.

[Andarist]

What are the two versions?

I mean those imported from prop-types package and those imported from react.

It' working on your whole Babel setup. If you let babel traverse the node_modules, this plugin will too. Noticed that most people only let babel traverse their source code.

Would be cool then if we can have include option here in this package to overwrite global setting.

I don't understand, nothing is supposed to stop that transform to work.

skip this one for now, its probably my fault as i exclude node_modules in my babel transform

[oliviertassinari]

I mean those imported from prop-types package and those imported from react.

We don't touch that for now by default. You can try the removeImport option out. react. is a deprecated pattern, we don't handle it.

Would be cool then if we can have include option here in this package to overwrite global setting.

I guess you are referring to the include option of babel-loader, not the same story here. You can ignore the node_modules with that option: https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types#ignorefilenames.

All of that should be in the README. If something isn't clear. Feel free to improve it 😄 .

[Andarist]

We don't touch that for now by default. You can try the removeImport option out. react. is a deprecated pattern, we don't handle it.

Ok, hopefully libraries will catch up soon with the change. Ive already setup removeImport :)

I guess you are referring to the include option of babel-loader, not the same story here. You can ignore the node_modules with that option: https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types#ignorefilenames.

I had in mind rather reversed scenario. I dont want to run any babel transformations on libraries code, except this one. So I would need something like includeFilenames

[oliviertassinari]

I had in mind rather reversed scenario. I dont want to run any babel transformations on libraries code, except this one.

I don't see how an includeFilenames option would be of any help. Babel plugins are not supposed to choose which files to parse. It's supposed to be on userland. This ignoreFilenames option is already an exception. You can run this only plugin programmatically with the Babel API (see the tests for instance). I don't see any better option.

[Andarist]

Ofc this should be applied in the userland, but there is no option for this transform to run on specific files in opt-in manner. Only opt-out

…

On Mon, 24 Apr 2017 at 18:03, Olivier Tassinari ***@***.***> wrote: Closed #100 <#100> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#100 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJWMkglCc5eGJ8iyHVXHfnT5-ruN56KKks5rzMfmgaJpZM4NGUcG> .

[oliviertassinari]

@Andarist Well, we would accept a PR for that. But in order to work, you need to configure Babel to traverse that file.