Comments (5)
For the record, I'm using React 15, and I've spotted the issue down to
if (superClass.matchesPattern('React.Component') || superClass.matchesPattern('Component')) {
path.remove();
}
In AssignmentExpression
: superClass.matchesPattern('Component')
returns false because of the second line of the matchesPattern
function that return false at line 2:
if (!this.isMemberExpression()) return false;
Changing superClass.matchesPattern('Component')
to superClass.node.name === 'Component'
solves my issue but I guess it's a wrong fix :)
from babel-plugin-transform-react-remove-prop-types.
@romainneutron Thanks for this feedback.
Can you confirm that this pattern is working?
import React, { Component } from 'react';
export default class MyComp extends Component {
static propTypes = {
name: React.PropTypes.object
};
render() {
//...
}
}
That sounds like the right direction.
We should refactor the AssignmentExpression
to use some part of the ClassProperty
logic.
from babel-plugin-transform-react-remove-prop-types.
I confirm @oliviertassinari , it works better using your snippet
from babel-plugin-transform-react-remove-prop-types.
@romainneutron I have just merged a fix.
from babel-plugin-transform-react-remove-prop-types.
Thanks for your fast response
from babel-plugin-transform-react-remove-prop-types.
Related Issues (20)
- 0.4.16 bug: Cannot read property 'referencePaths' of undefined at VariableDeclarator, lib/index.js:292:56 HOT 6
- Cannot read property 'type' of undefined at memberExpressionRootIdentifier HOT 1
- react-portal remove prop-types HOT 2
- mode wrap broken in 0.4.20(#168) HOT 2
- Ability to remove `contextTypes` HOT 6
- "unsafe-wrap" mode crashes when a type is referenced from a variable
- Support createReactClass alternatives via config HOT 4
- Cannot get "name" of undefined
- Is it supports react-native? HOT 9
- Destructured PropTypes are not removed HOT 4
- Doesn't work with react-navigation library
- Issue when used with `createReactClass` HOT 1
- Option to include only certain files
- Support for configure wrap condition HOT 4
- Rename wrongly in switch/case statement
- Not working for SFC forwardRef() and createContext()
- Doesnโt remove propTypes in certain situations HOT 2
- Transform error with mode=wrap for TypeScript class component static propTypes type definition HOT 4
- How to use it with multiple environments in babel-env?
- swc support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babel-plugin-transform-react-remove-prop-types.