Giter Site home page Giter Site logo

Comments (3)

oliviertassinari avatar oliviertassinari commented on May 24, 2024 1

@avindra I have added a test with an already transpiled code. It's not working for all the cases. #39.

from babel-plugin-transform-react-remove-prop-types.

oliviertassinari avatar oliviertassinari commented on May 24, 2024 1

I'm closing this issue. The wrap mode is used in production with Material-UI (.babelrc). This approach is working for us so far. We might have some edge cases. But I'm confident, we can address them.

from babel-plugin-transform-react-remove-prop-types.

oliviertassinari avatar oliviertassinari commented on May 24, 2024

Should we be convincing package authors to add this plugin to their builds with the wrap mode on?

I think that convincing package authors to use the wrap option of this plugin would be an efficient strategy.
Most of them are already publishing an es5 version of their package using Babel.

For one moment, I was worried about how we would handle es6 published version.
No much package authors are publishing one as we are speaking, I don't have any test running under those conditions, but I believe it's already supported. #fingercrossed 🎌 .

I have no clue regarding package authors using TypeScript.

I've tried just running the babel cli tool to strip propTypes from the compiled build

That's an interesting approach. We should support it, I have never tried it.

from babel-plugin-transform-react-remove-prop-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.