Giter Site home page Giter Site logo

Comments (4)

oliviertassinari avatar oliviertassinari commented on May 24, 2024

@piuccio I think that it's out of the scope of this modules.
Besides, the displayName are already removed by Uglify when using the ES6 class and the stateless functional component API.
Are you using the soon deprecated React.createClass API?

from babel-plugin-transform-react-remove-prop-types.

piuccio avatar piuccio commented on May 24, 2024

I'm using stateless functions

export default commentCount;
function commentCount ({ count }) {
        return (
            <span>comments <span className="comment-count">({count})</span></span>
        );
}

commentCount.displayName = 'CommentCount';
commentCount.propTypes = {
    count: React.PropTypes.number
};

Which becomes

    function commentCount(_ref) {
            var count = _ref.count;

            return React.createElement(
                "span",
                null,
                "comments ",
                React.createElement(
                    "span",
                    { className: "comment-count" },
                    "(",
                    count,
                    ")"
                )
            );
    }

    commentCount.displayName = 'CommentCount';

.displayName isn't removed by uglify, and I don't see why it should.

I understand it's out of scope, but was hoping someone had a solution. A quick google search didn't give much.

from babel-plugin-transform-react-remove-prop-types.

oliviertassinari avatar oliviertassinari commented on May 24, 2024

I'm using stateless functions

Oh, why not using the following syntax?

const CommentCount = ({ count }) => (
  <span>
    comments <span className="comment-count">{count}</span>
  </span>
);

CommentCount.propTypes = {
  count: React.PropTypes.number
};

export default CommentCount;

You still get the name of the component in the dev tool and a small output.

After babel transpilation:

"use strict";

exports.__esModule = true;

var CommentCount = function CommentCount(_ref) {
  var count = _ref.count;
  return React.createElement(
    "span",
    null,
    "comments ",
    React.createElement(
      "span",
      { className: "comment-count" },
      count
    )
  );
};

CommentCount.propTypes = {
  count: React.PropTypes.number
};

exports.default = CommentCount;

After Uglify minification:

"use strict"
exports.__esModule=!0
var CommentCount=function(e){var t=e.count
return React.createElement("span",null,"comments ",React.createElement("span",{className:"comment-count"},t))}
CommentCount.propTypes={count:React.PropTypes.number},exports["default"]=CommentCount

from babel-plugin-transform-react-remove-prop-types.

piuccio avatar piuccio commented on May 24, 2024

great, that worked! thanks

from babel-plugin-transform-react-remove-prop-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.