Giter Site home page Giter Site logo

Comments (4)

oliviertassinari avatar oliviertassinari commented on May 13, 2024

IMHO, the pattern 1 is far better. It could also be something like:

      <EventListener
        target={window}
        onScroll={{
          handler: this.handleScroll,
          options: {
            capture: false,
            passive: true,
         }
        }
      />

from react-event-listener.

wadackel avatar wadackel commented on May 13, 2024

Implementation of withOptions was thinking the following such simple things.

export function withOptions(handler, options) {
  return { hanlder, options };
}

I think that your code may be simple !

from react-event-listener.

oliviertassinari avatar oliviertassinari commented on May 13, 2024

@tsuyoshiwada In that case, I don't see the harm in having a withOptions helper πŸ‘ .
I'm not sure users will us it. But anyway.

from react-event-listener.

wadackel avatar wadackel commented on May 13, 2024

Thanks!
It is also likely to be easy to extend by cutting as a Function πŸ˜„

It sends a PR After implementing this!

from react-event-listener.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.