Here are a couple of 'first' changes I'd like to make to the code. I

first small changes about fake6502 HOT 2 CLOSED

john-walsh commented on August 23, 2024

first small changes

from fake6502.

Comments (2)

omarandlorraine commented on August 23, 2024

Those are great ideas that should absolutely be included here. I look forward to it!

Do I create a new branch (?) within this project, and then push my changes into my branch?

The easiest (and usual) way on github is if you fork the project. This will make a repo on your account, identical to mine. Here you can create a branch where you implement your changes. Then, after pushing, you can create a pull request from the feature branch on your repository into my repository.

from fake6502.

john-walsh commented on August 23, 2024

OK, got it.

What version number do you want this branch to be/start at?

Are we 1.2 now, or should we bump it up to 2.0?

Remember, I've got more changes to suggest.

Oh, and one more suggestion for a change to the header file:

Adding the C++ wrapper:

#ifdef __cplusplus
extern "C" {
#endif

...

#ifdef __cplusplus
}
#endif

Personally, I don't use C++, but in the spirit of being a source code library, it should be accounted for.