Dash intercepts links to header files of application classes.

[omz]

Dash intercepts links to header files of application classes.

[wearhere]

This is a regression since 80bc156. The way it used to work was that, in -om_handleLinkClickWithActionInformation:, -om_shouldHandleLinkClickWithActionInformation: would return NO and the plugin would let Xcode handle the click. Perhaps the plugin is now intercepting the URL before -om_handleLinkClickWithActionInformation: kicks in.

[Kapeli]

-om_handleLinkClickWithActionInformation: still handles things. This is the action information I'm seeing:

    WebActionButtonKey = 0;
    WebActionElementKey =     {
        WebElementDOMNode = "<DOMText [#text]: 0x128890cf0 'Terminal'>";
        WebElementFrame = "<WebFrame: 0x7fa0a11e7470>";
        WebElementIsContentEditableKey = 0;
        WebElementIsInScrollBar = 0;
        WebElementIsSelected = 0;
        WebElementLinkIsLive = 1;
        WebElementLinkLabel = "SLTerminal.h";
        WebElementLinkTitle = "";
        WebElementLinkURL = "file:///Users/bogdan/Library/Developer/Shared/Documentation/DocSets/com.inkling.Subliminal.docset/Contents/Resources/Documents/SLTerminal.h";
        WebElementTargetFrame = "<WebFrame: 0x7fa0a11e7470>";
    };
    WebActionModifierFlagsKey = 0;
    WebActionNavigationTypeKey = 0;
    WebActionOriginalURLKey = "file:///Users/bogdan/Library/Developer/Shared/Documentation/DocSets/com.inkling.Subliminal.docset/Contents/Resources/Documents/SLTerminal.h";

If you look at wearhere@80bc156#diff-6f1abccc519eaee8c98910b91d43e956L148 at line 151 you'll see that the return nil was removed. What that return nil used to do is NSBeep() if the regex didn't match anything.

So, before 80bc156 things still did not work, the only difference it was that it NSBeep'd instead of triggering a Dash search.

I'll fix this exact scenario by refusing to handle links that have a path that ends in .h. Can you think of other scenarios where this might happen?

[wearhere]

Not off the top of my head--we should refuse to handle any links with extensions, but I think it would be safest to blacklist those extensions explicitly to avoid misinterpreting a period somewhere else in a URL.

[Kapeli]

Great. I'll leave things as-is and will adjust if any other bugs are reported. Thanks once again for your help! 👍