Giter Site home page Giter Site logo

Comments (8)

yaikhomba avatar yaikhomba commented on September 4, 2024

@bluecypher - for Flow 2, Plotch (Indiastack buyer app) is sending different transaction_id with every SELECT call.

from v1.1.0-logs.

yaikhomba avatar yaikhomba commented on September 4, 2024

@BLR-0118 & @bluecypher - there is no "ttl" in quote in on_update as per the API specification. Could you please confirm if "ttl" needs to be added in quote in on_update?

from v1.1.0-logs.

yaikhomba avatar yaikhomba commented on September 4, 2024

@BLR-0118, @bluecypher - why do we need to keep message_id for an unsolicited /on_update same with a previous /update call? These introduces chances of mismatch.
Can we just pick the message_id of any previous /update?

from v1.1.0-logs.

sandeepshahi avatar sandeepshahi commented on September 4, 2024

@yaikhomba
quote/ttl need not be removed from the APIs, it should remain the same as in /confirm
message id for the unsolicited /on_update should be same as in /update to track that particular part return/part cancel request

from v1.1.0-logs.

sandeepshahi avatar sandeepshahi commented on September 4, 2024

Flow 1

/on_status

  • Order pickup time (/fulfillments/start/time/timestamp) should remain same as in Order-picked-up fulfillment state
  • Order pickup time (/fulfillments/start/time/timestamp) and order delivery time (/fulfillments/end/time/timestamp) can't be same when order is delivered (fulfillment state is Order-delivered)

/on_update

  • /on_update must return the same information trail as in /on_status (order created_at, updated_at, payment etc.)

Flow 2

/on_select

  • invalid payload /select1 (different txn)
  • time_to_ship (O2S) in /on_search can't be equal to @ondc/org/TAT (O2D) in /on_select

Flow 3, 4

  • similar issues as Flow 1

@yaikhomba

from v1.1.0-logs.

yaikhomba avatar yaikhomba commented on September 4, 2024

@BLR-0118 @bluecypher
Flow 1
/on_update - payload is as per the API spec.
Flow 2
Could you elaborate this - "invalid payload /select1 (different txn)". I see that transactions ids are same across.

from v1.1.0-logs.

sandeepshahi avatar sandeepshahi commented on September 4, 2024
  • As per the API spec, it is mentioned that /on_update must return the same information as /on_status (all the required attributes must be present).
  • check f2_select_1.json in Flow 2. (which is an invalid payload)

@yaikhomba

from v1.1.0-logs.

yaikhomba avatar yaikhomba commented on September 4, 2024

@bluecypher - for the /on_update was following the payload listed in the spec. Will include the others attributes.
The json payload f2_select_1.json you are referring for select was from the previous submission and not part of the latest submission.

from v1.1.0-logs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.