Comments (13)
from v1.1.0-logs.
Flow 1
/init
- invalid attributes ("tracking", "@ondc/org/category") in /fulfillments
/confirm
- billing timestamps (created_at and updated_at) can't change (should remain same as in /init)
- invalid attributes ( "@ondc/org/withholding_amount", "@ondc/org/return_window", "@ondc/org/settlement_basis","@ondc/org/settlement_window") in /payment
- payment/transaction_id should be different from context/transaction_id
- order/created_at timestamp should match context/timestamp
/status
- missing /on_status response for this status call @ 2023-05-16T12:30:06.794Z
- missing order delivery status (/on_status) call
/update
- /message/order/state must be "Completed" (instead of "COMPLETED")
- invalid payment object in part return case
- refund flow is missing (should be called in separate /update for refund triggering states)
- invalid /on_update response (no return status for the returned item), these scenarios should be handled by the buyer app.
Flow 2
- Non-serviceable flow is missing (should be handled by buyer app)
- seller unsolicited cancellation is missing
/init
- billing timestamps (created_at, updated_at) should match context.timestamp
/confirm
- /message/order/payment/@ondc/org/buyer_app_finder_fee_type must be "percent" (in lower case)
/cancel
- invalid cancellation reason id for buyer side cancellation refer this
Flow 3
- seller rejecting the return request flow is missing
Flow 4, 5
- similar issues as above
- txn id should not change for select calls
from v1.1.0-logs.
@BLR-0118 @bluecypher
All fixed except these two below. I need discussion on these points. I will raise PR now for other fixes.
- refund flow is missing (should be called in separate /update for refund triggering states)
- invalid /on_update response (no return status for the returned item), these scenarios should be handled by the buyer app.-
from v1.1.0-logs.
all done here @BLR-0118
from v1.1.0-logs.
Flow 1, 4
- refund flow is missing
Flow 2
- Non-serviceable flow is missing (should be handled by buyer app)
- seller unsolicited cancellation is missing
Flow 5
/cancel
- use one of the non-deprecated cancellation reason codes
from v1.1.0-logs.
@bluecypher Refund flow is already there. can you look into it here
- https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow1/on_update.json
- https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow1/update.json
- https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow3/on_update.json
- https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow3/update.json
- https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow4/on_update.json
- https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow4/update.json
seller unsolicited cancellation is missing
Api is exposed and none of the seller provided the on call.
use one of the non-deprecated
Please share the reason code . i got below codes
001,003,004,006
from v1.1.0-logs.
/init
- door is an optional attribute in /billing/ and /fulfillments/end/location/address/
- provider_id is an optional attribute in /fulfillments
Flow 2
- Why is a new /search initiated when location is changed? (/select should be called instead since item is already in the cart)
- unsolicited /on_cancel uses buyer side cancellation_reason_id. How is it handled at buyer app's end?
Flow 4
- refund flow is missing
Flow 5
/cancel
- "004" is a deprecated cancellation_reason_id (use "006" instead)
from v1.1.0-logs.
@bluecypher @BLR-0118
/cancel
"004" is a deprecated cancellation_reason_id (use "006" instead) . We are sending 006 only. Closely see the request.
refund flow is missing
We have shared this update and unsolicited log in PR and in call you have seen that. Can you share what is missing in it?
refer here
https://github.com/ONDC-Official/v1.1.0-logs/pull/242/files#diff-1c973b5aa89eb8eeda58bb17b8e739d4afabddae84ce1e7f52fe4c9c04c40824
/init
door is an optional attribute in /billing/ and /fulfillments/end/location/address/ ,
we are taking is as an optional only
provider_id is an optional attribute in /fulfillments
we are taking is as an optional only
from v1.1.0-logs.
Flow 1
- /update_refund: API call & refund amount calculation are wrong;
- curious why message_id is in one format until /init and then has a different format?
After fixing the above, request QC testing to verify the following:
- serviceability
- store timings & holidays
- handling of out-of-stock items
- processing of status updates
- processing of cancel from seller
- processing of refunds for return, cancel
@jainneerajnj @bansalmeghaa @bluecypher
from v1.1.0-logs.
from v1.1.0-logs.
Flow 1
/update_refund: API call & refund amount calculation are wrong;
Fixed
curious why message_id is in one format until /init and then has a different format?
Fixed
@BLR-0118 @bluecypher @bansalmeghaa
from v1.1.0-logs.
Rechecked logs.
Flow 1: /on_update_liquidated quote is wrong. Item liquidated should be part of the quote with qty as 0. Buyer app should respond with NACK for this.
from v1.1.0-logs.
from v1.1.0-logs.
Related Issues (20)
- Tata Digital BA (RSF) - Compliance Check HOT 9
- Addble (IGM) - compliance check HOT 3
- Oogashop (RSF) -compliance check HOT 6
- nStore BAP (RSF) - compliance check
- Phonepe (IGM) - compliance check HOT 3
- Pidge (IGM) - compliance check HOT 1
- Pidge (LSP) - compliance check
- n-store (IGM) - compliance check HOT 5
- GRAB (RSF) - compliance check HOT 6
- Adya (IGM) - compliance check HOT 2
- Digiit LSP (RSF) - compliance checks HOT 5
- eSamudaay SNP (RSF) - compliance check HOT 6
- TVS_E (IGM) - compliance check HOT 5
- MP2 TSP LSP - compliance check HOT 4
- Adloggs LSP - compliance check HOT 1
- Growthfalcon IGM - compliance check HOT 5
- Adloggs (IGM) - complaince check HOT 4
- ESamudaay (SA) RSF - compliance check HOT 7
- ShiSellerApp (RSF) - compliance check HOT 3
- Adloggs (LSP) RSF - compliance check HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from v1.1.0-logs.