Kotak - compliance check

[BLR-0118]

Kotak - compliance check

[BLR-0118]

@taukilali

[sandeepshahi]

Flow 1

/init

• invalid attributes ("tracking", "@ondc/org/category") in /fulfillments

/confirm

• billing timestamps (created_at and updated_at) can't change (should remain same as in /init)
• invalid attributes ( "@ondc/org/withholding_amount", "@ondc/org/return_window", "@ondc/org/settlement_basis","@ondc/org/settlement_window") in /payment
• payment/transaction_id should be different from context/transaction_id
• order/created_at timestamp should match context/timestamp

/status

• missing /on_status response for this status call @ 2023-05-16T12:30:06.794Z
• missing order delivery status (/on_status) call

/update

• /message/order/state must be "Completed" (instead of "COMPLETED")
• invalid payment object in part return case
• refund flow is missing (should be called in separate /update for refund triggering states)
• invalid /on_update response (no return status for the returned item), these scenarios should be handled by the buyer app.

Flow 2

• Non-serviceable flow is missing (should be handled by buyer app)
• seller unsolicited cancellation is missing

/init

• billing timestamps (created_at, updated_at) should match context.timestamp

/confirm

• /message/order/payment/@ondc/org/buyer_app_finder_fee_type must be "percent" (in lower case)

/cancel

• invalid cancellation reason id for buyer side cancellation refer this

Flow 3

• seller rejecting the return request flow is missing

Flow 4, 5

• similar issues as above
• txn id should not change for select calls

@taukilali

[taukilali]

@BLR-0118 @bluecypher

All fixed except these two below. I need discussion on these points. I will raise PR now for other fixes.

• refund flow is missing (should be called in separate /update for refund triggering states)
• invalid /on_update response (no return status for the returned item), these scenarios should be handled by the buyer app.-

[taukilali]

all done here @BLR-0118

[sandeepshahi]

Flow 1, 4

• refund flow is missing

Flow 2

• Non-serviceable flow is missing (should be handled by buyer app)
• seller unsolicited cancellation is missing

Flow 5

/cancel

• use one of the non-deprecated cancellation reason codes

@taukilali

[taukilali]

@bluecypher Refund flow is already there. can you look into it here

• https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow1/on_update.json
• https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow1/update.json
• https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow3/on_update.json
• https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow3/update.json
• https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow4/on_update.json
• https://github.com/ONDC-Official/v1.1.0-logs/blob/main/kotak/flow4/update.json

seller unsolicited cancellation is missing
Api is exposed and none of the seller provided the on call.

use one of the non-deprecated
Please share the reason code . i got below codes
001,003,004,006

[sandeepshahi]

/init

• door is an optional attribute in /billing/ and /fulfillments/end/location/address/
• provider_id is an optional attribute in /fulfillments

Flow 2

• Why is a new /search initiated when location is changed? (/select should be called instead since item is already in the cart)
• unsolicited /on_cancel uses buyer side cancellation_reason_id. How is it handled at buyer app's end?

Flow 4

• refund flow is missing

Flow 5

/cancel

• "004" is a deprecated cancellation_reason_id (use "006" instead)

@taukilali

[taukilali]

@bluecypher @BLR-0118

/cancel

"004" is a deprecated cancellation_reason_id (use "006" instead) . We are sending 006 only. Closely see the request.

refund flow is missing

We have shared this update and unsolicited log in PR and in call you have seen that. Can you share what is missing in it?
refer here
https://github.com/ONDC-Official/v1.1.0-logs/pull/242/files#diff-1c973b5aa89eb8eeda58bb17b8e739d4afabddae84ce1e7f52fe4c9c04c40824

/init

door is an optional attribute in /billing/ and /fulfillments/end/location/address/ ,
we are taking is as an optional only
provider_id is an optional attribute in /fulfillments
we are taking is as an optional only

[BLR-0118]

Flow 1

1. /update_refund: API call & refund amount calculation are wrong;
2. curious why message_id is in one format until /init and then has a different format?

After fixing the above, request QC testing to verify the following:

1. serviceability
2. store timings & holidays
3. handling of out-of-stock items
4. processing of status updates
5. processing of cancel from seller
6. processing of refunds for return, cancel
   @jainneerajnj @bansalmeghaa @bluecypher

[bansalmeghaa]

+Shishir Jindal ***@***.***> +Santosh Adsul ***@***.***> +Pooja Pawar ***@***.***> +Abhinandan Satpute ***@***.***> Megha

…

On Mon, 29 May 2023 at 00:04, Supriyo Ghosh ***@***.***> wrote: Flow 1 1. /update_refund: API call & refund amount calculation are wrong; 2. curious why message_id is in one format until /init and then has a different format? After fixing the above, request QC testing to verify the following: 1. serviceability 2. store timings & holidays 3. handling of out-of-stock items 4. processing of status updates 5. processing of cancel from seller 6. processing of refunds for return, cancel @jainneerajnj <https://github.com/jainneerajnj> @bansalmeghaa <https://github.com/bansalmeghaa> @bluecypher <https://github.com/bluecypher> — Reply to this email directly, view it on GitHub <#224 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4RKYE3E3F2H4F4FQAYZUXLXIOLD7ANCNFSM6AAAAAAYBJTRCA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[taukilali]

Flow 1
/update_refund: API call & refund amount calculation are wrong;
Fixed
curious why message_id is in one format until /init and then has a different format?

Fixed
@BLR-0118 @bluecypher @bansalmeghaa

[BLR-0118]

Rechecked logs.
Flow 1: /on_update_liquidated quote is wrong. Item liquidated should be part of the quote with qty as 0. Buyer app should respond with NACK for this.

[BLR-0118]

@taukilali