Comments (18)
@bluecypher
/search fixed all the mentioned issues in both flows
/init fixed fixed all the mentioned issues in both flows
/confirm fixed all the mentioned issues in both flows
/update submitted logs for this in happy flow
/cancel fixed all the mentioned issues in cancel flow
from v1.1.0-logs.
Happy Flow
/search
- Either one of fixed timings (range) or split timings (both frequency and times) should be provided in /provider/time
- Incorrect mapping of gps and address of store location. (reverse geocding shows different pincode)
/init
- billing.created_at should match context.timestamp
- billing.updated_at should match context.timestamp
/confirm
- /message/order/@ondc/org/linked_order/items/quantity/count must be integer
/update
- @ondc/org/order_ready_to_ship should be 'yes' (lowercase)
- order.created_at cannot change in /update
Cancel Flow
- similar issues as above Flow
from v1.1.0-logs.
@abhinavv245 fixed all the issues..please have a look
from v1.1.0-logs.
Happy Flow
- Avoid replicating test data from the contract
/search
- holidays cannot be past dated in /schedule
/init
- fulfillments/id should correspond to the one returned in /on_search
- /message/order/billing must have required property 'tax_number'
- /message/order/fulfillments/start/location/address must have required property 'building'
- /message/order/fulfillments/end/location/address must have required property 'building'
- /message/order/billing/address must have required property 'building'
- door is an optional/to be depracted attribute in /billing/address
- end/location/gps should not change (precision should be minimum 6 decimal places)
/confirm
- /message/order/fulfillments/end must have required property 'person'
- @ondc/org/order_ready_to_ship should be 'no' (lowercase)
/update
- start attribute required for ready to ship fulfillment in update api
Cancel Flow
- similar issues as above
from v1.1.0-logs.
@abhinavv245 raised a PR with all fixes
from v1.1.0-logs.
Both Flows
/confirm
- payment object is missing in /order
Please remove all previous versions of logs and resubmit only the revised version
from v1.1.0-logs.
If the order is prepaid, the logistics buyer should not include "@ondc/org/settlement_details" in the payment. When making the confirm call, if we receive "@ondc/org/settlement_details": null during on_init, what action should be taken?
@abhinavv245
from v1.1.0-logs.
@Namratha102000 you can send the type of payment and who is collecting it. '@ondc/org/settlement_details' is an optional attribute and can be omitted in case it is null or empty.
from v1.1.0-logs.
@abhinavv245 raised a PR with fix
from v1.1.0-logs.
Happy Flow
/confirm
- order/created_at and order/updated_at cannot be future dated w.r.t context/timestamp
Cancel Flow
/cancel
- LSP needs to cancel the order through unsolicited on_cancel. /cancel is not required
from v1.1.0-logs.
@abhinavv245 fixed in PR
from v1.1.0-logs.
/update
- pickup confirmation code is mandatory for P2P
- Auto-RTS should be supported in /confirm
- unsolicited calls for /on_status should also be supported
Cancel-Flow
- How is this cancel flow processed? LSP has cancelled the order with reason code 012, without picking the package from store (no pickup timestamp)
from v1.1.0-logs.
@bluecypher @abhinavv245
Happy flow -
- Added pickup confirmation code
- Auto-RTS should be supported in /confirm - It is supported
- unsolicited calls for /on_status should also be supported it is supported and added the logs for these calls
Cancel - flow
- In the new logs order is moved to picked status ....and then cancelled
from v1.1.0-logs.
- RTO charges are not provided in /on_search. Should be handled accordingly.
/on_status
- message_id mismatch with /status (seems like unsolicited call)
- Order has been delivered, but the delivery timestamp is still missing; Pickup timestamp does not match with timestamp provided in unsolicited call for "Order-picked-up" state.
- This call should have been rejected with a NACK
Cancel-Flow
- After the RTO initiation, are the RTO charges correctly handled?
from v1.1.0-logs.
@bluecypher
- RTO charges are 1.2 update..right?
- The on_status issue was a fault by the Loadshare team, which they have now fixed. Therefore, I am raising a PR again, but this time, it is only for the happy flow.
from v1.1.0-logs.
- RTO charges are part of v1.1.0 as well
- Why is logistics procurement limited to P2P deliveries and not for P2H2P?
from v1.1.0-logs.
@bluecypher @abhinavv245
As of now, we have only enabled P2P (Point-to-Point) logistics to ensure efficient and direct communication between buyers and sellers.
from v1.1.0-logs.
@BLR-0118, eSamudaay Logistics BAP logs (v1.1.0) seem fine, Please proceed with your review.
from v1.1.0-logs.
Related Issues (20)
- Tata Digital BA (RSF) - Compliance Check HOT 9
- Addble (IGM) - compliance check HOT 3
- Oogashop (RSF) -compliance check HOT 6
- nStore BAP (RSF) - compliance check
- Phonepe (IGM) - compliance check HOT 3
- Pidge (IGM) - compliance check HOT 1
- Pidge (LSP) - compliance check
- n-store (IGM) - compliance check HOT 5
- GRAB (RSF) - compliance check HOT 6
- Adya (IGM) - compliance check HOT 2
- Digiit LSP (RSF) - compliance checks HOT 5
- eSamudaay SNP (RSF) - compliance check HOT 6
- TVS_E (IGM) - compliance check HOT 5
- MP2 TSP LSP - compliance check HOT 4
- Adloggs LSP - compliance check HOT 1
- Growthfalcon IGM - compliance check HOT 5
- Adloggs (IGM) - complaince check HOT 4
- ESamudaay (SA) RSF - compliance check HOT 7
- ShiSellerApp (RSF) - compliance check HOT 3
- Adloggs (LSP) RSF - compliance check HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from v1.1.0-logs.