Comments (1)
First and foremost, JS Arrays shall be iterated via
for (i=0; i<arr.length; i++)
and NOT using "for (var p in arr)" notation. This might be common in other languages (PHP comes to mind), but is generally frowned upon in JS. Alternatively, a functional notation (forEach) is also suitable.
Not only numeric iteration completely prevents the issue mentioned above; it is also way faster. Iterating through object keys internally creates a new array (as in Object.keys()) and walks through its items. Direct numeric access does not require any temporary array. Please re-factor your code so you iterate arrays numerically.
Finally, the general idea with non-enumerable properties does not sound bad, but I doubt that all canvas-supporting browsers will be able to handle that (Opera 10/11 comes to mind). I will investigate the level of support.
from rot.js.
Related Issues (20)
- ROT.RNG.setSeed unexpected behavior HOT 9
- Is it possible to generate a dungeon from some room templates HOT 2
- How to reset the speed-scheduler? HOT 1
- Simple scheduler schedules items after removal HOT 5
- eventque.js in the lib folder does not successfully import MinHeap HOT 2
- Create an ESM Build
- Publish drawOver to npm? HOT 2
- Pathfinding based on ending callback instead of position HOT 5
- Best practices for running rot.js server-side? (and emitting the display to the client) HOT 4
- Basic game example HOT 1
- Map generation preloader HOT 1
- RNG.clone().setSeed() does not function as expected HOT 8
- What is the minimum "safe" size for Rogue map? HOT 4
- Sporadic divergence while playing replays with set seed HOT 7
- Better signature for optional function parameters HOT 2
- [question] Is this library still being maintained? HOT 1
- corridorLength max doesn't seem to be respected HOT 7
- Extending (extruding?) rot.js HOT 16
- Differences in FOV calculation depending on position HOT 1
- Consider adding a typo check in github action? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rot.js.