Giter Site home page Giter Site logo

Comments (6)

vpirogov avatar vpirogov commented on June 7, 2024

@SriAlavandar, verbose logs specifies a function called by the application as the fourth parameter. In your case Tensorflow calls 3 different functions: inner product, matmul, and dnnl::sgemm. The fifth parameter indicates underlying implementation name (like brg_avx512_core) for specific function.

Adding @agramesh1 to cover Tensorflow implementation decisions.

from onednn.

vpirogov avatar vpirogov commented on June 7, 2024

+@orelyehuda

from onednn.

SriAlavandar avatar SriAlavandar commented on June 7, 2024

Hi @yehudaorel, @agramesh1 Did you get any chance to have a look into the above issue. what is the importance of reorder to tag::abcd to tag::acbd? is reorder done on Matrix B?

from onednn.

yehudaorel avatar yehudaorel commented on June 7, 2024

Hi @SriAlavandar, I believe your assumption here is correct, the reorder is taken place before matmul operation to reorder weight matrix to optimal memory format dictated by tensorflow implementation. In this case, the verbose output shows reorder from NCHW (channels first) to NHWC (channels last).

from onednn.

SriAlavandar avatar SriAlavandar commented on June 7, 2024

Thanks @yehudaorel. I noticed only for few MatMul's reorder on weight matrix is being triggered.
image
Can you please let me know on what basis are we deciding here whether reorder needs to be triggered or not?

from onednn.

yehudaorel avatar yehudaorel commented on June 7, 2024

Hi @SriAlavandar, there are many reasons for a reorder primitive to be executed, one of them being matrix transposition which seems to be the case here. Without full context to the model implementation I don't have a definitive answer but I would recommend to run tensorboard profiler and verify tensorflow-onednn operation mapping.

e.g
image

from onednn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.