Error with TBB CMake on OS X

[oneapi-src]

Error with TBB CMake on OS X

[AlexVeprev]

Hi @izaid,

Thank you for the detailed description!
I've reproduced the issue and found a root cause in incorrect TBBConfig.cmake installed with TBB package.
Looks like Homebrew generates this TBBConfig.cmake using scripts provided by TBB (homebrew-core/Formula/tbb.rb:37), but the TBB CMake scripts support configuring packages provided by TBB team via GitHub only. These packages have different structure from Homebrew packages.

The most evident to me ways to resolve it:

1. Improve TBB CMake config generators to support Homebrew structure. I can propose the implementation; it will be available when TBB with the improvement is released and Homebrew takes the release.
2. Write a CMake module finding pre-installed TBB (it's going to be done in scope of PR #13). This approach will work when Parallel STL delivers the module. Or you can write your own implementation for your project (I suppose, it'll be quite simple if you're going to use it with Homebrew TBB only, I can help if needed).

@henryiii, could you please take a look? Maybe you have something to add.

[rodgert]

@AlexVeprev Erk, I don't currently have a means of testing OSX/Homebrew changes (my MBP is out for repair) but I'd be interested in a fix to this as well. If nobody beats me to it, I will attempt to fix it when I get my Mac back.

This is a bit of slippery slope though since now there's Brew for Linux, should that also be supported?

[henryiii]

@AlexVeprev , quick historical perspective. The problem is that ParallelSTL now has its own CMake config, which expects a working TBB Config (by request of Intel). I warned about the broken TBBConfig in brew back then, and the solution was "fix the one in Brew", which is quite correct, but also does not seem to have been done.

Edit: Or it was added but doesn't handle brew correctly, now that I'm looking at this more closely.

You can add a fix to Homebrew's formula to patch the Config file for now, too.

[izaid]

Just wanted to say thanks for looking into this. For now, I'm not going to use ParallelSTL's CMake files, but hopefully will be able to as soon as they work with brew.

[AlexVeprev]

@rodgert, I think it would be better to have support for many popular package managers (including DNF mentioned in PR #13). But initially it is enough to have support for things required asap.

@henryiii, thank you for the explanation!

[rodgert]

@AlexVeprev agreed. FWIW, it works fine with Fedora28 and DNF as is (that's my primary development platform).

[AlexVeprev]

I've pushed a PR simplifying FindTBB.cmake into @rodgert repo in order to include it into PR #13 (or into a separate PR if there are objections).

This FindTBB.cmake works for me on Mac with TBB installed using Homebrew.
You are welcome for review.

[tbbdev]

Hi @izaid,
In the release 20181204 we added FindTBB CMake module as a Preview Feature. It is invoked from Parallel STL CMakeLists.txt.
Could you please check if this solves your issue?

[hjmjohnson]

@tbbdev Fixes for this problem are oneapi-src/oneTBB#119
and temporary changes are listed as a temporary homebrew patch at:
Homebrew/homebrew-core#36175

[tbbdev]

The issue is fixed in Homebrew TBB formula: Homebrew/homebrew-core#38844