Only warn that Airplane Mode is on when we can't connect

[onebusaway]

Only warn that Airplane Mode is on when we can't connect

[paulpv]

I run in to this confusion all of the time when working with people that are using my product.
Don't think of airplane mode as anything special to handle.
All the app should care about is "do I have any network connection", which doesn't have much/anything to do with airplane mode.
The app should just watch network connectivity events and only try to connect if there is any network connection (and only warn/toast if there is no network connection).

[paulcwatts]

With this commit, that's essentially what happens. The only difference is the toast message, which will give a hint to the user that they can't connect perhaps because Airplane Mode is on.

Many of OneBusAway's users are relatively tech unsavvy -- the reason why I added that check in the first place is I got a bunch of email complaints that the app wasn't working, only to find out that the user had enabled Airplane Mode.

[paulpv]

Understood, but you still are treating airplane mode as something special.
I recommend renaming your "isAirplaneMode()" to something like "!isAnyNetworkConnectionAvailable()", and change the method to do just that.
The difference may seem subtle or petty, but can be pretty important.

In my product I have to run as a service and stream audio in the background, so I have to real-time detect this by creating a PhoneStateListener and a BroadcastReceiver for ConnectivityManager.CONNECTIVITY_ACTION that takes action whenever any connection is lost or established.

[paulcwatts]

isAirplaneMode() I think is named correctly, because that's exactly what it does -- it returns true if Airplane Mode is enabled, false otherwise. It seems like "!isAnyNetworkConnectionAvailable" is what isConnected does.

If you'd like to improve OneBusAway's handling of no connectivity situations beyond what I've done, I'd encourage you to file a Pull Request.