Giter Site home page Giter Site logo

Comments (4)

paulcwatts avatar paulcwatts commented on June 12, 2024

I suspect this was an oversight. What are the reasons for not calling super.onCreate?

from onebusaway-android.

barbeau avatar barbeau commented on June 12, 2024

Sorry, I worded that sentence poorly, and I just fixed it in the original post. There are no advantages that I know of, but I wanted to check with you to see if there was a reason for omitting it.

from onebusaway-android.

paulcwatts avatar paulcwatts commented on June 12, 2024

If there were a reason I should have commented it as such, but I'm guessing there probably wasn't. Feel free to fix it.

from onebusaway-android.

barbeau avatar barbeau commented on June 12, 2024

Looking at the Android platform code, I don't believe calling super.onCreate() will actually have any affect on current Android devices, as its a no-op method:
https://github.com/android/platform_frameworks_base/blob/master/core/java/android/app/Application.java#L75

So, there shouldn't be any negative affect on current devices if we add the call to super.onCreate().

I'll fix this and submit via a pull request.

from onebusaway-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.