Multi-row not working

[onemen]

Multi-row not working

[onemen]

this error is related, since we don't have _scrollbox

Uncaught TypeError: can't access property "scrollLeft", tabstrip._scrollbox is undefined
    afterTabTitleChanged chrome://tabmixplus/content/places/places.js:554
    TMP_onTabTitleChanged chrome://tabmixplus/content/minit/tablib.js:1844
    _setTabLabel chrome://tabmixplus/content/changecode.js line 218 > eval:32
    setTabTitle chrome://tabmixplus/content/changecode.js line 218 > eval:65
    onLocationChange chrome://browser/content/tabbrowser.js:6204

i added this at the top of tabsBindings.js

  // temporary workaround until we fix multi-row feture
  if (!gBrowser.tabContainer.arrowScrollbox._scrollbox) {
    gBrowser.tabContainer.arrowScrollbox._scrollbox = {};
  }

[117649]

mat be use 'gBrowser.tabContainer.arrowScrollbox.scrollbox'?

tabstrip._scrollbox -> tabstrip.scrollbox

[onemen]

I need to work on converting scrollbox.xml to extend MozArrowScrollbox

[117649]

I need to work on converting scrollbox.xml to extend MozArrowScrollbox

https://bgrins.github.io/xbl-analysis/converter/
This site just come in handy for generate CE from XBL.
Just copy paste XML into left box and you get JS from right box.
You still have to tinker here and there though but its much easier.

Base on how shadow DOM slot works and the constructor of the <arrowscrollbox>:
(use the first shadow <scrollbox>)
the process could be as much simple as:

1. once you have the Custom Element ready define it to still use the <scrollbox> tag.
2. In shadow-root of the <arrowscrollbox> create a instance of your <scrollbox> with a <html:slot> child.
3. Insert the created <scrollbox> before the original one thus it should automatically replace the older.
4. Remove the old element.

I leave it untouched when I was converting the tab bindings because I have no idea how multi-row and scroll box binding works.

[onemen]

Thank you for the tip @117649, i will look into it later today

[117649]

I'm sorry, I wasn't quite understand what 'scrollbox.xml' is doing back then thus my advice may be misleading.
Its looks like 'scrollbox.xml' just adding the scroll buttons on the right of tab bar not messing with the <arrowscrollbox>.
I think for that you can just create buttons with js and use the css of <arrowscrollbox>.

Any success on this article?

[onemen]

Yes.

I have it working for normal tabs need more work for pinned tabs

[117649]

Anything I can help with?