Comments (5)
Hi @NoahMLoomis 👋.
You are indeed right. I didn't pay attention to that at all. Thank you for the remark and especially for making a PR to correct it.
I am happy to accept your contribution to the project.
I thank you very much and I hope you will be there for other features as the package is young.
from react-tailwindcss-datepicker.
PR here: #2
from react-tailwindcss-datepicker.
@NoahMLoomis
I noticed in your PR you had made these changes.
value: {
startDate: string | Date,
endDate: string | Date
} | null,
onChange: (value: {startDate: string | Date, endDate: string | Date} | null) => void
But the values of startDate and endDate should be able to be null. An example would be when you delete the form.
Then it should be
value: {
startDate: string | Date | null,
endDate: string | Date | null
} | null,
onChange: (value: {startDate: string | Date | null, endDate: string | Date | null} | null) => void
from react-tailwindcss-datepicker.
But I took this into account in the patch for version 1.1.1
from react-tailwindcss-datepicker.
Awesome! Good catch
from react-tailwindcss-datepicker.
Related Issues (20)
- Value not displaying HOT 2
- Editing value manually doesn't update widget if done at the start
- Missing comma in demo code
- Calendar not showing previous month when using different dayjs.locale()
- id attribute not passed on to underlying input
- custom classnames
- Feature Request: Can you add a time range, e.q. 08:00 - 14:00
- Masks
- Read-only mode not working
- State of the project HOT 1
- Modal is not adjusting according to height HOT 2
- Pop up is displayed below another component despite a higher z Index container
- Weird date selection behaviour in react tailwindcss datepicker
- Add shortcutClassName property HOT 1
- Hide/show year feature
- Selected date background is not showing. HOT 1
- fix for inside of accordion
- DatePicker won't reset on reset button press within an html form
- Support typical input field aspects such as tabIndex
- Add support for date localization
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-tailwindcss-datepicker.