Giter Site home page Giter Site logo

Comments (2)

onevcat avatar onevcat commented on May 24, 2024 1

Currently the requestModifier option only keeps the last value, it is not linkable and cannot be called in a chain.

Instead of setting multiple . requestModifier, you need to create a "multiple version" of ImageDownloadRequestModifier yourself, like this:

final class ConcatenatedRequestModifier: ImageDownloadRequestModifier {
    let modifiers: [any ImageDownloadRequestModifier]
    init(modifiers: [any ImageDownloadRequestModifier]) {
        self.modifiers = modifiers
    }
    
    func modified(for request: URLRequest) -> URLRequest? {
        var r = request
        for modifier in modifiers {
            if let modified = modifier.modified(for: r) {
                r = modified
            } else {
                return nil
            }
        }
        return r
    }   
}

Indeed it is a good idea to allow the option accepts multiple .requestModifier as a chained behavior. However, it breaks the current behavior and usage (although this should be a rare use case). I will consider it in the following major upgrade!

Thanks for the suggestion.

from kingfisher.

nodediggity avatar nodediggity commented on May 24, 2024

Ah thank you so much, I misunderstood how it works, your suggestion worked perfectly.

Feel free to close this, I really appreciate the speedy response 🙏

from kingfisher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.