Comments (4)
The fix is to simply include periods in the regex character class (square brackets).
from oztree.
Maybe we should bin the regex replacement, and feed a "ignore URL base" option to set_treestate()
, so we don't try and go from /life_expert -> /life (for example).
That said, I don't think set_treestate()
would actually change pages if passed a full URL anyway, and maybe it would never make sense to do so?
from oztree.
so we don't try and go from /life_expert -> /life (for example)
That would not happen, since we have underscore in the character class, no?
I was just trying to target the specific 'period' issue tactically with a minimal change, but if you think that a different change is best, we can do that instead.
from oztree.
That would not happen, since we have underscore in the character class, no?
Yup, I'm not arguing against your fix, which is a good catch and worth applying.
My point is more that the whole regex-replacement will probably bite us again in the future, and could probably be binned & replaced with a special case in set_treestate()
more robustly. But it's certainly not a high-priority thing.
from oztree.
Related Issues (20)
- Remove grunt-curl to get rid of dependabot warnings
- myconf.take('paypal.save_to_tmp_file_dir') should be wrapped with exception handling HOT 2
- JS TypeError in OZentry, when evaluating e.length HOT 10
- unformatted {pic} string in node_details.json HOT 12
- Getting 'Invalid pinpoint' errors with alternate tree. Should life.html be tree agnostic? HOT 2
- Treeviewer stalls if node_details API returns empty data HOT 2
- Clean run results in modifications to en-us.py HOT 15
- web2py installation requires `deposit` and `logs` directories in root folder HOT 3
- Natural view type leaf sponsorship text position error HOT 1
- sponsor_renew_request not redirecting after sending mail HOT 4
- Tour engagement counter HOT 1
- Remove `.html` from internal URL() links. HOT 2
- invalid literal for int() in resolve_pinpoint_to_row HOT 2
- Tour table search: "Illegal mix of collations" HOT 2
- Home page menubars overlap search box with smaller screen HOT 1
- OneZoom site hangs with in a JavaScript infinite loop if tree_startpoints table is empty HOT 7
- Upgrade test suite to use Pytest & selenium 4
- Wikimedia videos not playing HOT 1
- Add a few events to the hard-coded list in endorsements.html
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oztree.