FCL: requests to access node use the protocol of the host page instead of configured value

[onflow]

FCL: requests to access node use the protocol of the host page instead of configured value

[jimwheaton]

Further investigation traced the issue to https://github.com/improbable-eng/grpc-web/blob/master/client/grpc-web-node-http-transport/src/index.ts#L56

this.options.url is correctly set to http://localhost:8080/access.AccessAPI/GetAccount. However, when the code above sets httpOptions, it does not set the protocol. Line 66 is executed, calling http.request(httpOptions, ...). The body of http.request looks like the snippet below. TLDR is that it will make the request without the protocol specified, so the browser will append https: since that is the current window protocol.

http.request = function (opts, cb) {
	if (typeof opts === 'string')
		opts = url.parse(opts)
	else
		opts = extend(opts)

	// Normally, the page is loaded from http or https, so not specifying a protocol
	// will result in a (valid) protocol-relative url. However, this won't work if
	// the protocol is something else, like 'file:'
	var defaultProtocol = global.location.protocol.search(/^https?:$/) === -1 ? 'http:' : ''

	var protocol = opts.protocol || defaultProtocol
	var host = opts.hostname || opts.host
	var port = opts.port
	var path = opts.path || '/'

	// Necessary for IPv6 addresses
	if (host && host.indexOf(':') !== -1)
		host = '[' + host + ']'

	// This may be a relative url. The browser should always be able to interpret it correctly.
	opts.url = (host ? (protocol + '//' + host) : '') + (port ? ':' + port : '') + path
	opts.method = (opts.method || 'GET').toUpperCase()
	opts.headers = opts.headers || {}

	// Also valid opts.auth, opts.mode

	var req = new ClientRequest(opts)
	if (cb)
		req.on('response', cb)
	return req
}

I'm going to open up an issue on the grpc-web repo

[orodio]

House keeping, tagging and closing in favour of: #321