Cannot build from source (sdist) from PyPI.

[ccoulombe]

Cannot build from source (sdist) from PyPI.

[AdilZouitine]

@ccoulombe This pull request #1506 should fix your issue, thanks for pointing it out 😄

[MaxHalford]

@AdilZouitine any clue?

[AdilZouitine]

Hi there,

After a quick glance into the problem, it seems like the switch to poetry might be the culprit here (this is a hypothesis). Poetry overlook the MANIFEST.in file, which is necessary for specifying additional files needed in the sdist, like the Cargo.toml file for Rust extensions. Here's what's currently in the MANIFEST.in:

cat MANIFEST.in
global-include *.cpp
global-include *.pyx
global-include *.pxd
include river/datasets/*.csv
include river/datasets/*.gz
include river/datasets/*.zip
include river/stream/*.zip
include Cargo.toml
recursive-include rust_src *

Because of this shift to poetry, the Cargo.toml file isn't making it into the sdist, which is why building river from the sdist fails. For a fix, we need to move all these includes into the pyproject.toml file. Poetry manages package building through pyproject.toml, not MANIFEST.in, so we have to ensure everything we need is specified there.

I will try to test this fix this afternoon.

[AdilZouitine]

Issue Fixed we can close it 😄