Comments (4)
donbox
commented on May 21, 2024
The Proto/no-Proto suffix inconsistency has bothered me as well.
I'm fine unnesting the message definitions. Again, we are inconsistent.
If we are doing this, we should do it today or tomorrow.
It won't be a breaking change on the wire format so we shouldn't have to regen the PBs in AWS, but it will break all of our code.
Who wants to prep the PR?
from onnx.
prasanthpul
commented on May 21, 2024
Sorry @yuanbyu - I managed to delete your comment. :(
I agree with you that this makes sense to do.
from onnx.
prasanthpul
commented on May 21, 2024
@donbox @ezyang Is this still applicable and do we want to do it?
from onnx.
ezyang
commented on May 21, 2024
Yes, I think we should still do it.
from onnx.
Related Issues (20)
- Create test for validating shape-inference methods handle unknown rank inputs
- Define DepthToSpace as function
- Using Pytorch Count of input_names provided during export not matching with session.get_inputs() HOT 1
- ONNX is broken when built with ONNX_USE_LITE_PROTO=OFF (using protobuf-24.4): File already exists in database: onnx/onnx-ml.proto HOT 5
- Schema error trying to create new version of training ops
- ERROR: Could not build wheels for onnx which use PEP 517 and cannot be installed directly HOT 2
- output different between onnx and pytorch HOT 7
- Implement DepthToSpace as a function HOT 2
- Reference implementation of ONNX Reduce sum square is mismatch with ONNX Spec when noop_with_empty_axes == 1 HOT 5
- Clarification of Reshape semantics for attribute 'allowzero' NOT set, zero volume HOT 3
- Change dynamic shape in fixed shape using C++ HOT 1
- The weekly model zoo CI has been failing HOT 12
- Incorrect input names for quantize/dequantize ONNX backend node tests HOT 1
- Fix and test numpy_helper to_array
- How to read onnx and obtain names, imgsz HOT 3
- Model zoo test failures HOT 1
- DequantizeLinear spec clarification: What happens if the subtraction overflows/underflows? HOT 1
- the model for UniqueOp in backend test is not always correct for different input
- A conflict doc abount compatibility between Onnx Version & ML Opset Version HOT 2
- [Shape Inference] Robustness of `ConstantOfShape` operator HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onnx.