onsdigital/eq-questionnaire-runner

eq-questionnaire-runner's Issues

Date validation broken when using custom error messages

Expected behaviour

When a validation message is overridden for a date field, any other validation (date too early or late) should continue to work.

Actual behaviour

An HTTP 500 error is generated.

Steps to reproduce the behaviour

• Start a census individual questionnaire
• Select "A private or family household"
• Select "For someone else"
• Enter a name
• Enter a date of birth of 1800 or 2200

Screenshot

Missing primary person names when using "Save and sign out"

Expected behaviour

The user is taken to the list collector driving question.

Actual behaviour

Skipped past the mandatory name question and no answers to the name question are stored for the primary person.

Steps to reproduce the behaviour

1. Launch census_household_eb_eng. Keep a note of the response_id.
2. Click Continue on the Interstitial page.
3. Select No, I don’t usually live here then Save and continue.
4. Click Previous
5. Select Yes, I usually live here then Save and continue.
6. On thee add screen, click Save and sign out.
7. Relaunch the same survey with the same response_id.

You should now be skipped past the add screen and a primary person should have been added to the household without any values for first/last name.

Technical information

This only works when you have taken the No route first.

Browser

Operating System

Screenshot

Section summary page title does not render placeholders when using custom section summary title

Expected behaviour

The page title should be using the rendered placeholder.

Actual behaviour

Using a placeholder for the custom summary title, the raw placeholder is displayed as the page title.

Steps to reproduce the behaviour

• Launch test_section_summary.json
• Steps: Answer Both > Save & Continue > Save & Continue > Save & Continue
• You should now be on the household section summary for which the page title is the raw placeholder.

Technical information

Page title needs to use the rendered placeholder not the raw JSON fetched from schema.

Browser

Operating System

Screenshot