Giter Site home page Giter Site logo

Comments (10)

FernandaFarinelli avatar FernandaFarinelli commented on September 9, 2024 1

Thanks for letting me know.
I'm in the process to generate a new version of ONTONEO adjusting any issues. I'll verify this too.

from ontoneo.

matentzn avatar matentzn commented on September 9, 2024 1

Hey @FernandaFarinelli looks better :) Thanks. Not quite right yet: You have:
http://purl.obolibrary.org/obo/ontoneo/ONTONEO_00100001

But the correct IRI should be:

http://purl.obolibrary.org/obo/ONTONEO_00100001

Thank you very much for doing it, this will greatly help with including ONTONEO in other projects!

from ontoneo.

matentzn avatar matentzn commented on September 9, 2024 1

@FernandaFarinelli That looks great. The only thing i noticed about the IRIs is inconsistent length, which can lead to some errors:

http://purl.obolibrary.org/obo/ONTONEO_1000000
http://purl.obolibrary.org/obo/ONTONEO_1000001
http://purl.obolibrary.org/obo/ONTONEO_1000002

These three properties have 7 digits, while all your other terms have 8. I recommend prepending a 0 or something to make them 8 digits to be consistent across the ontology Otherwise, great.

from ontoneo.

matentzn avatar matentzn commented on September 9, 2024 1

Its up to you @FernandaFarinelli
these IRIs are perfectly valid - but it may be confusing to some tools that chop the URI into a number and prefix part:
Imagine this:
ONTONEO:1000000
ONTONEO:01000000

These are definitely two different IRIs, but if you were to check "which one is higher", and you go with the numeric id, they would end up as being the same.. which may cause problems. That said, you did not anything wrong and can chose to leave it as is. My recommendation: Obsolete the three ids and replace by new ones.

from ontoneo.

FernandaFarinelli avatar FernandaFarinelli commented on September 9, 2024

Nico Matentzoglu,
I did some updates on Ontoneo.
Could you check again? Feel free to let me know about any other issue in Ontoneo.
I'll wait your reply to close this issue.
Thanks.

from ontoneo.

zhengj2007 avatar zhengj2007 commented on September 9, 2024

The incorrect IRI still used in the latest ONTONEO release.

For example,
gestational age measurement datum
http://purl.obolibrary.org/obo/ontoneo/ONTONEO_00000255

Could all the ONTONEO terms use the OBO normalized IRI? Thanks!

from ontoneo.

FernandaFarinelli avatar FernandaFarinelli commented on September 9, 2024

I'm working on this.

from ontoneo.

zhengj2007 avatar zhengj2007 commented on September 9, 2024

@FernandaFarinelli Thanks a lot!

from ontoneo.

FernandaFarinelli avatar FernandaFarinelli commented on September 9, 2024

@matentzn and @zhengj2007
I made such changes on ontoneo.
Please let me know if everything is ok.
Thanks for your patient.
Fernanda

from ontoneo.

FernandaFarinelli avatar FernandaFarinelli commented on September 9, 2024

@matentzn I have a doubt about this strategy. If I prepending a 0 it will be a new IRI ?

Maybe, to be stable IRIs I should create these three properties again, with a new 8 digits IRI and replace them in all my ontology.

In addition, I should transform these three properties in the obsolete class as a subclass of http://www.geneontology.org/formats/oboInOwl#ObsoleteClass, and inform in these old properties the annotation "term replace by" (IAO_0100001) and maybe the annotation "has obsolescence reason"(IAO_0000231).

What do you think about it? What is the best and simple strategy?

Thanks for your contribution.

from ontoneo.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.