Giter Site home page Giter Site logo

Formatting versions about go-logging HOT 11 CLOSED

op avatar op commented on August 18, 2024
Formatting versions

from go-logging.

Comments (11)

jbenet avatar jbenet commented on August 18, 2024

Those are go vet errors, by the way.

from go-logging.

nwolff avatar nwolff commented on August 18, 2024

+1. I have configured go vet errors to fail my automated builds, and these false positives don't help.

from go-logging.

op avatar op commented on August 18, 2024

Is there a way to instruct go vet to not report these errors? I've decided to not break backwards compatibility.

At the same time I've been thinking of moving this project to eg. github.com/go-logging/log, break backwards compatibility there, remove and clean it up a bit and have it in "experimental" state for a while. Right now I don't have time to do this. Any thoughts?

from go-logging.

nwolff avatar nwolff commented on August 18, 2024

Another option is to introduce semantic versions maybe with something like http://labix.org/gopkg.in

I've never done it but I use this library that uses it: https://github.com/alecthomas/kingpin

I guess it would mean creating a new branch and pointing "gopkg.in/op/go-logging.v2" to it.

from go-logging.

giftig avatar giftig commented on August 18, 2024

Incidentally I use goyaml via gopkg.in, and it seems like a pretty neat solution.

from go-logging.

optimality avatar optimality commented on August 18, 2024

What about (for example) just introducing Errorf as an alias for Error? That would enable us to use Errorf to avoid go vet noise without breaking backwards compatibility.

from go-logging.

nwolff avatar nwolff commented on August 18, 2024

@optimality it looks like an ok short-term solution if @op does not want to create a v2

The main remaining problem would be that some non-f methods such as Error expect a format, while others such as Panic don't, making things somewhat confusing.

from go-logging.

optimality avatar optimality commented on August 18, 2024

@op Have you reached a decision on this?

from go-logging.

gdm85 avatar gdm85 commented on August 18, 2024

Sorry, but if go vet reports an error by default with this, I'd prefer to stick to go vet and fork/fix the bug.

from go-logging.

gdm85 avatar gdm85 commented on August 18, 2024

Right now I am using this syntax to workaround the problem:

go tool vet -printf=false src/

It would be best if I could get rid of this incomplete and error-prone workaround...

from go-logging.

op avatar op commented on August 18, 2024

This is fixed now.

from go-logging.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.