Comments (11)
Those are go vet
errors, by the way.
from go-logging.
+1. I have configured go vet errors to fail my automated builds, and these false positives don't help.
from go-logging.
Is there a way to instruct go vet to not report these errors? I've decided to not break backwards compatibility.
At the same time I've been thinking of moving this project to eg. github.com/go-logging/log, break backwards compatibility there, remove and clean it up a bit and have it in "experimental" state for a while. Right now I don't have time to do this. Any thoughts?
from go-logging.
Another option is to introduce semantic versions maybe with something like http://labix.org/gopkg.in
I've never done it but I use this library that uses it: https://github.com/alecthomas/kingpin
I guess it would mean creating a new branch and pointing "gopkg.in/op/go-logging.v2" to it.
from go-logging.
Incidentally I use goyaml via gopkg.in, and it seems like a pretty neat solution.
from go-logging.
What about (for example) just introducing Errorf as an alias for Error? That would enable us to use Errorf to avoid go vet noise without breaking backwards compatibility.
from go-logging.
@optimality it looks like an ok short-term solution if @op does not want to create a v2
The main remaining problem would be that some non-f methods such as Error expect a format, while others such as Panic don't, making things somewhat confusing.
from go-logging.
@op Have you reached a decision on this?
from go-logging.
Sorry, but if go vet
reports an error by default with this, I'd prefer to stick to go vet
and fork/fix the bug.
from go-logging.
Right now I am using this syntax to workaround the problem:
go tool vet -printf=false src/
It would be best if I could get rid of this incomplete and error-prone workaround...
from go-logging.
This is fixed now.
from go-logging.
Related Issues (20)
- change delimiter in output format
- Logger registry singleton
- Duplicate print in log HOT 3
- *Logger type uses global backend in IsEnabledFor method
- log rotate functionality HOT 1
- build fails on raspberry pi 3 running debian stretch HOT 1
- Diffrent format / config for diffrent level HOT 1
- Set Logging Level HOT 5
- Add mqttlog backend to README
- Getting formatted logs in file and on cmd HOT 1
- go1.12 and too many arguments HOT 1
- Test failure: TestLogCallpath incorrect callpath HOT 2
- Disable logging HOT 1
- Rotating files HOT 1
- How to customize the request id? HOT 1
- Add a standard logger
- Question: Can you set maximum logging level HOT 1
- How to turn off line numbers in production env? HOT 1
- How do I set up multiple log files?
- [Question] How to log to a file? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-logging.