Giter Site home page Giter Site logo

Comments (6)

mrvanes avatar mrvanes commented on May 23, 2024 1

No, my suggestion was not to use the "accept" header, that's just to show a correct SCIM request body. My suggestion is to be lenient about the returned application/<anything+>json Content-Type.

from opa.

anderseknert avatar anderseknert commented on May 23, 2024

Sounds like a reasonable improvement to me. If you'd like to submit a PR, that'd be neat 🙂

from opa.

srenatus avatar srenatus commented on May 23, 2024

"For more information, please re-read." -- I've removed my comment re force_json_decode, you're already aware. 😅

from opa.

srenatus avatar srenatus commented on May 23, 2024

💭 Right now, application/json is json-decoded, and application/yaml + application/x-yaml are yaml-decoded. So if we go with

users_request := {
    "url": "https://scimserver/Users",
    "method": "GET",
    "headers": {
        "x-api-key": "secret",
        "accept": "application/scim+json"
    }
}

would this mean it should do JSON? How would I declare that a certain extra header value means that it should be treated as YAML?

from opa.

srenatus avatar srenatus commented on May 23, 2024

Ah! Thanks for clarifying. Yeah, that makes this a bit simpler.

from opa.

ashutosh-narkar avatar ashutosh-narkar commented on May 23, 2024

This method handles the response processing which would need to be updated I think. Feel free to submit a PR if you'd like. Thanks.

from opa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.