Comments (11)
Are you seeing errors?
It would be preferred to fix this while fixing an actual error, otherwise optimization for sake of optimization is not needed at this time.
from ai.
No, I am not seeing any errors, I just noticed that when I started working on #88
from ai.
The code refactor and description generation button click handlers do have try/catch blocks implemented to handle errors generated from the API calls.
from ai.
The issue with warping the whole function in try/catch is that when I tried to use the functions inside this by itself, like: getDescript, description stream, I had to warp that with a try/cacth again. I think having try catch the base would be more ideal.
what your thoughts? @Anush008
from ai.
The idea is to have the caller handle the thrown errors as required.
from ai.
I think more specific errors could be handled, but we'll just log them all anyway, no other mechanism to deal with any of the for now.
So this can be done later.
from ai.
So, should we keep this open until it's done later? So that we will not forget it?
from ai.
It's just that when you call functions that throw, you can handle them as required. There's no way around it. It isn't appropriate to handle the error in the function definition since the caller might need a different behaviour on error.
It isn't something that needs to be fixed or improved.
from ai.
You can think about it as something similar to API calls, when you got 401 for example it's not throwing an error, but it's returning a response with response.ok
state if it's okay then you can move forward.
Here you can check the insights project logic:
from ai.
@a0m0rajab can you share an example of an error from our project? That'll help in tackling the issue too, if there is one :)
from ai.
@diivi it's more of a I could not use the util functions since that did not provide a try/catch stuff rather than an error I faced.
from ai.
Related Issues (20)
- chore: add CODEOWNERS file HOT 2
- Monthly issue metrics report
- Bug: unable to login - Chrome HOT 9
- Monthly issue metrics report HOT 1
- Feature: add blocking labels to the take action HOT 1
- Bug: AI extension is not showing the PR writing message HOT 7
- Feature: refactor constant naming HOT 3
- Feature: enable AI description generator for all PRs even on comments HOT 2
- Bug: unstable AI Description HOT 3
- Bug: repository chatbot tracker issue HOT 3
- Bug: AI description generator on comments is not enabling the comment button HOT 2
- Bug: repo name is being empty HOT 1
- POC: E2E test with Playwright HOT 9
- Bug: Can't generate refactor, test, and explanation code when clicking the OpenSauced orange button HOT 1
- Bug: OpenSauced orange button doesn't appear on the PR form
- Bug: Can't generate Highlight from an issues HOT 4
- Feature: show a message to user when they are not logged in HOT 2
- fix: Add correct path to the usage guide on README and Docs in the extension, and update "Contributing" and "Community" sections in README HOT 3
- Bug: Lint error: Expected linebreaks to be 'LF' but found 'CRLF' HOT 6
- Bug: Can't run `npm run push` to commit changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ai.