Giter Site home page Giter Site logo

Comments (8)

0-vortex avatar 0-vortex commented on June 13, 2024 2

We should use some of the code from: https://ariakit.org/examples/menu

It's already accessible and has the functionality we need.

Think we are using https://www.radix-ui.com/docs/primitives/components/dropdown-menu in hot :D

Sorry for the late message had a severe injury 😅

from app.

chadstewart avatar chadstewart commented on June 13, 2024 2

Think we are using https://www.radix-ui.com/docs/primitives/components/dropdown-menu in hot :D

Sorry for the late message had a severe injury sweat_smile

Yeah, we should probably use the component already in hot since we intend of building a design system across all the applications so we might as well borrow already built components from the other projects.

from app.

bdougie avatar bdougie commented on June 13, 2024 1

I comment on the wrong issues, but here is some context. #4 (comment)

We historically hide things that don't need to be in the header nav, i.e. "open an issue on github" link.

In the absence of a user profile, the dropdown should provide links specific to the user's experience.

  1. Logout is a minimum requirement
  2. I like having the report an issue link here.
  3. Perhaps we can link the changelog here too.

from app.

pixelsbyeryc avatar pixelsbyeryc commented on June 13, 2024

We have to define what's going to be under the Dropdown Menu... Is it only "Log out"? @chadstewart @bdougie

from app.

chadstewart avatar chadstewart commented on June 13, 2024

We have to define what's going to be under the Dropdown Menu... Is it only "Log out"? @chadstewart @bdougie

So right now, I think just having "log in" when there's no logged in user and "log out" when there's a logged in user present is good enough for now.

from app.

pixelsbyeryc avatar pixelsbyeryc commented on June 13, 2024

We should use some of the code from: https://ariakit.org/examples/menu

It's already accessible and has the functionality we need.

from app.

pixelsbyeryc avatar pixelsbyeryc commented on June 13, 2024

That's perfect!

from app.

github-actions avatar github-actions commented on June 13, 2024

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.