Comments (4)
% git diff -w svn-release-0.6.0-rc2 32009b1 -- include/json/value.h
...
- CZString &operator =( const CZString &other );
+ CZString &operator=(CZString other);
...
- Value &operator=( const Value &other );
+ Value &operator=(Value other);
Yes, those 2 signatures have changed. Not good. (I am comparing tag svn-release-0.6.0-rc2
with commit 32009b17e4d35a812575cfcf6bae9ec49fc67446
, which preceded our Clang reformatting.)
Let me see if I can add those back and delegate to the others. I'm not sure whether that would actually compile...
from jsoncpp.
Billy, 45cd949 broke binary compatibility. I don't want Debian to bump the .so version. So we have to consider some choices:
A. Revert this on the pre-C++11 branch.
B. Keep it, but add the old signatures too, and let those delegate to the new ones. Will that compile?
C. Keep it as is. Maybe it's not a real problem. (But I don't think we can convince Debian folks of that.)
I'm going with A for now. What do you think?
from jsoncpp.
I would go with A as well. Revert on the branch Debian is pulling.
Or bump the patchlevel on the .so.
I didn't realize Debian would be pulling from a trunk branch and expecting
binary compatibility.
That seems like a pretty fragile setup!
On Mon, Nov 17, 2014 at 12:57 AM, Christopher Dunn <[email protected]
wrote:
Billy, 45cd949
45cd949
broke binary compatibility. I don't want Debian to bump the .so version. So
we have to consider some choices:A. Revert this on the pre-C++11 branch.
B. Keep it, but add the old signatures too, and let those delegate to the
new ones. Will that compile?
C. Keep it as is. Maybe it's not a real problem. (But I don't think we can
convince Debian folks of that.)I'm going with A for now. What do you think?
—
Reply to this email directly or view it on GitHub
#78 (comment)
.
from jsoncpp.
Yes, I think worrying about binary compatibility unwise. But in our case, it was easy. I'll tag that as 0.6.0
.
I'm about to tag the tip as 0.7.0
. Then I'll bump to 1.0.0
on master and call it officially C++11 only.
from jsoncpp.
Related Issues (20)
- find_package(jsoncpp REQUIRED) failed HOT 2
- Range constructor HOT 1
- Serialization
- Support cmake config with meson build HOT 1
- It has been almost two years since jsoncpp released. May I know when the next one will be? HOT 1
- In Windows 10 Education Edition 21H2 using json 1.9.3 to write json files, garbled characters
- May it better that using ArrayIndex= size_t rather than ArrayIndex=unsigned int? HOT 1
- jsoncpp using IStream = std::istream; conflict with WindowsSDK‘s include CommCtrl.h HOT 7
- VS2022 x64, building INSTALL fails ( napi not found in Dependencies folder ) HOT 1
- Trailing comma before comment in array crashes
- LF to CRLF
- VS2013 debug build crashes compiler
- terminate called after throwing an instance of 'Json::LogicError'
- GDB pretty print support
- How to set both key and value pair as variable
- Can't Cross Compiling jsoncpp 00.11.z for aarch64 HOT 5
- Tests write to source tree when invoked via CMake
- Undefined reference to things HOT 2
- Why are the branches of the if statement not implemented consistently?
- CMake 3.27 warns about compatibility with CMake <3.5 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsoncpp.