collector does not include nginx receiver

[open-telemetry]

collector does not include nginx receiver

[jpkrohling]

The linked PR is needed, but the components.go from that repository isn't used in the distribution. A new one is generated by the builder:

https://github.com/open-telemetry/opentelemetry-collector/blob/b34df3a7e7e9ea6dba20608c2f1f53bedc2a3d22/cmd/builder/internal/builder/main.go#L67

[nslaughter]

... the components.go from that repository isn't used in the distribution. A new one is generated by the builder ...

Thank you for explaining. I was missing that.

Should I plan to open another PR here in releases after the one in contrib can be merged?

[TylerHelmuth]

/cc @djaglowski

[jpkrohling]

Looks like it's missing from the manifest: https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml

[nslaughter]

@jpkrohling I understand that this issue means the manifest needs to be updated, but could you explain why the issue should be on the opentelemetry-collector-releases repo? Thank you.

[jpkrohling]

The manifest resides here, in the -releases repository.

[TylerHelmuth]

I think the issue is bigger than the manifest. As @nslaughter mentioned, the factory isn't setup in components.go. Without the factory I don't think the component can get made.

[jpkrohling]

Yes, please.

[djaglowski]

Thanks @nslaughter.

@jpkrohling, is there a heuristic for which components should be added to contrib's components.go?

Based on the guidelines established in contrib#9412, perhaps we should eventually expect that contrib's components.go and the corresponding manifest in this repo should both contains all components that are Alpha or higher.

[TylerHelmuth]

I agree, if it's not "in development" anymore it should be included in distributions and contrib's local execution.