Should the main module on this repo be made internal?

[open-telemetry]

Should the main module on this repo be made internal?

[jpkrohling]

It should indeed be internal.

@silverlyra, what do you think?

[Aneurysm9]

I think as @jpkrohling mentioned here, this should be handled through configuration and not code changes. Even if it does require a code change, I'm not sure that mutable tags are ever the correct answer. We've seen enough problems caused by others doing that, can we please not become part of the problem by normalizing that behavior?

[jpkrohling]

I agree in principle, but this specific repo is only used for releases. The only deliverables are the containers and binaries, and as long as they are not published, it's safe to remove and retag.

That said, we should only do it after careful consideration and make a decision as a team. The default answer should indeed be to produce a patch release.

I still think retagging v0.47.0 on this repository here was the right answer.

[mx-psi]

I second @jpkrohling with this. I would never suggest doing this on opentelemetry-collector or opentelemetry-collector-contrib, but this repo is only used to publish releases.

I think we should avoid doing this as much as possible but, in the event that this is the best option in the future again, making the module internal will help avoid breakage, and it is also the right thing to do generally if we don't want people to rely on it.

I am interested in hearing what you think would break from this on this repository though, maybe we are missing something important

[mx-psi]

I tried doing this on #172. There is no public API, because if a package has a main function, it can't be imported. Therefore this is not a problem for moving tags in special situations.