Comments (11)
This requires updating our CI Dockerfile with a compiler supporting C++20. the ubuntu:20.04
image provides gcc version supporting C++20, however there's no gcc-4.8 package for this Ubuntu version.
What I would recommend:
- Adding a separate Dockerfile based on
ubuntu:20.04
. - Provide an option in run_ci.sh to switch between those images.
Alternatively, we might set up a Dockerfile based on ubuntu:20.04
that compiles and installs gcc-4.8 from source, but I think that's not worth the effort.
from opentelemetry-cpp.
You can use matrix build to build on older Ubuntu and 20.40. Example how I'm doing it in my fork to verify some ongoing C++20 work: https://github.com/maxgolov/opentelemetry-cpp/blob/master/.github/workflows/build-ubuntu.yml
from opentelemetry-cpp.
Would I be able to be assigned to implement this alongside my supervisor @alolita ?
from opentelemetry-cpp.
Hi, just running into a few roadblocks regarding this issue:
- In my forked repo, even though I change the Dockerfile to use 20.04, the testing fails with the same errors. Do I have to change other aspects of the Dockerfile or other bash script files for this process to run smoothly? (ie. where would I change the gcc version package, or is that already a part of the new Docker image? Or would I also have to create an install_gcc(supported version).sh and add that to the ci build pipeline?)
- If I were to take the first approach and create a second Dockerfile, where would this 20.04 dockerfile be located? Only 1 dockerfile can exist in a single folder, if I'm not mistaken. and if so, what would be the input that specifies using 18.04 as opposed to 20.04? Would it just be for this test and nothing else?)
-If I take the second (Max's) approach, where does that yaml file get called aside from pushes and pulls? If I am hoping to run the test on my computer whenever, where would I add the option for ubuntu 20.04, and all the other necessary components needed for the c++20 testing to work, in the ci folder?
@pyohannes @maxgolov
My apologies in advance for the confusion.
from opentelemetry-cpp.
Make sure to install g++-10, which provides latest support for C++20 and supports the -std=c++20
flag.
from opentelemetry-cpp.
Is this issue still relevant after merging #504 ?
from opentelemetry-cpp.
Is this issue still relevant after merging #504 ?
Seems so - #211 was supposed to provide fix ( Dockerfile with having C++20 compiler ).
from opentelemetry-cpp.
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.
from opentelemetry-cpp.
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.
from opentelemetry-cpp.
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.
from opentelemetry-cpp.
This issue is almost 3 years old now, and a lot of things have changed in the code and CI since then.
Closing.
Please reopen if the issue is still valid, and provide logs of the failure seen.
from opentelemetry-cpp.
Related Issues (20)
- Crash in OLTP HTTP export HOT 13
- [EXPORTER] OTLP HTTP session canceled after a flush, with async export HOT 2
- [REMOVAL] Remove build option `WITH_DEPRECATED_SDK_FACTORY` HOT 1
- [SECURITY] Remove OTLP HTTP support for TLS 1.0 and TLS 1.1, require TLS 1.2 or better HOT 1
- Internal abseil code compile error on gcc 14 HOT 1
- Triplet links in docs/building-with-vcpkg documentation are outdated.
- [EXPORTER] Spurious crash when using `PeriodicExportingMetricReader` and timeout.
- Latest API reference is for v1.11.0 HOT 1
- Cardinality limit on metrics (otel_metrics_overflow) HOT 3
- [CI] Build failures with ABSEIL 20240116 and CMAKE 3.30 HOT 4
- C++ Logger API does not compliant with the OTel Logs Data Model HOT 7
- Need suggestion when using histogram
- [RELEASE] Prepare patch release 1.16.1
- [EXPORTER] Allow construct OTLP gRPC exporters from existing `grpc::Channel`
- OTLP File exporter may crash if create thread failed HOT 2
- [API] Clarify expectations for C++ exceptions, and usage of noexcept methods. HOT 2
- Unresolved external symbol TracerProviderFactory::Create
- Failed to build HOT 1
- Specify OPENTELEMETRY_ABI_VERSION_NO with Bazel HOT 2
- Linker Error LNK2019: Unresolved External Symbol for OStreamSpanExporterFactory::Create
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-cpp.