Giter Site home page Giter Site logo

Comments (1)

dmathieu avatar dmathieu commented on July 16, 2024

From a quick grep, I'm finding only one non-test occurence.

open-telemetry/opentelemetry-go›  git:(main) grep -rn 'var .* T' .
./trace/config.go:38:   var config TracerConfig
./trace/tracestate.go:175:var _ json.Marshaler = TraceState{}
./trace/noop.go:26:var _ TracerProvider = noopTracerProvider{}
./trace/noop.go:36:var _ Tracer = noopTracer{}
./trace/tracestate_test.go:279:var maxMembers = func() TraceState {
./trace/tracestate_test.go:412:var insertTS = TraceState{list: []member{
./exporters/zipkin/internal/internaltest/errors.go:11:var _ error = TestError("")
./internal/internaltest/errors.go:11:var _ error = TestError("")
./internal/shared/internaltest/errors.go.tmpl:11:var _ error = TestError("")
./sdk/trace/evictedqueue.go:23: var tVal T
./sdk/internal/internaltest/errors.go:11:var _ error = TestError("")
./sdk/internal/x/x_test.go:50:  var zero T
./sdk/metric/internal/x/x_test.go:60:   var zero T
./sdk/metric/view.go:112:       var zero T
./propagation/propagation.go:37:var _ TextMapCarrier = MapCarrier{}
./propagation/baggage.go:20:var _ TextMapPropagator = Baggage{}

// nonZero returns v if it is non-zero-valued, otherwise alt.
func nonZero[T comparable](v, alt T) T {
var zero T
if v != zero {
return v
}
return alt
}

We could remove the generics in this method, by passing a third argument into the method which would be the zero value.
Creating views shouldn't be in the hot path though, as it happens once at boot time.

from opentelemetry-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.