Giter Site home page Giter Site logo

Comments (10)

rghetia avatar rghetia commented on July 22, 2024 2

reopening this as requested above.

from opentelemetry-go.

reicheltp avatar reicheltp commented on July 22, 2024 2

I am currently implementing those interceptors for our company. I'll send a PR as soon as they're ready.

from opentelemetry-go.

rghetia avatar rghetia commented on July 22, 2024 1

@sudeep-ib please open a new issue for stats.

from opentelemetry-go.

iredelmeier avatar iredelmeier commented on July 22, 2024

(for posterity)

There are (at least) three routes we can go with this:

  1. Use stats.Handler. This is what ocgrpc does.
  2. Use interceptors (UnaryClientInterceptor, StreamClientInterceptor, UnaryServerInterceptor, and StreamServerInterceptor). This is what both opentracing go-grpc and otgrpc do.
  3. Use some combination of both

stats.Handler exposes details such as the uncompressed and wire length of the payload, which aren't accessible through the interceptors.

On the other hand, the stream interceptors enable us to observe individual messages within the stream, rather than treating the whole stream as a single payload. stats.Handler doesn't facilitate this granularity. (Note that neither opentracing package currently does anything per-message, although it would probably be quite useful for many streaming use cases.)

Thoughts?

ETA: As far as consistency across languages goes, I don't believe that any other languages support an equivalent to stats.Handler. Some, but not all, support interceptors.

from opentelemetry-go.

rghetia avatar rghetia commented on July 22, 2024

Is it possible to associate different traces for each payload in case of stream interceptors? Otherwise long lived stream could end up having one parent creating 100s or 1000s of child span.

Can we support both with an option flag?

from opentelemetry-go.

iredelmeier avatar iredelmeier commented on July 22, 2024

Decision on the above, based on today's SIG, is to with interceptors at least for now. Longer term, we may do a combination of both.

from opentelemetry-go.

iredelmeier avatar iredelmeier commented on July 22, 2024

Closing this for now as I believe it makes sense to start with the converted Datadog gRPC plugin (as discussed in last week's SIG meeting), which we should be able to make public soon.

from opentelemetry-go.

inigohu avatar inigohu commented on July 22, 2024

Any updates about otgrpc plugin?

from opentelemetry-go.

glerchundi avatar glerchundi commented on July 22, 2024

Why was this issue closed? I think the decision to go through interceptors is a implementation detail but the feature request to create an interceptor/plugin still applies, right?

from opentelemetry-go.

sudeep-ib avatar sudeep-ib commented on July 22, 2024

The attached PR #621, addresses tracing but does not implement stats. Is there a roadmap to including the stats plugin in opentelemetry. Is there an Issue that tracks it, or we could re-open this one?
@rghetia @jmacd

from opentelemetry-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.