Comments (10)
reopening this as requested above.
from opentelemetry-go.
I am currently implementing those interceptors for our company. I'll send a PR as soon as they're ready.
from opentelemetry-go.
@sudeep-ib please open a new issue for stats.
from opentelemetry-go.
(for posterity)
There are (at least) three routes we can go with this:
- Use
stats.Handler
. This is what ocgrpc does. - Use interceptors (
UnaryClientInterceptor
,StreamClientInterceptor
,UnaryServerInterceptor
, andStreamServerInterceptor
). This is what both opentracing go-grpc and otgrpc do. - Use some combination of both
stats.Handler
exposes details such as the uncompressed and wire length of the payload, which aren't accessible through the interceptors.
On the other hand, the stream interceptors enable us to observe individual messages within the stream, rather than treating the whole stream as a single payload. stats.Handler
doesn't facilitate this granularity. (Note that neither opentracing package currently does anything per-message, although it would probably be quite useful for many streaming use cases.)
Thoughts?
ETA: As far as consistency across languages goes, I don't believe that any other languages support an equivalent to stats.Handler
. Some, but not all, support interceptors.
from opentelemetry-go.
Is it possible to associate different traces for each payload in case of stream interceptors? Otherwise long lived stream could end up having one parent creating 100s or 1000s of child span.
Can we support both with an option flag?
from opentelemetry-go.
Decision on the above, based on today's SIG, is to with interceptors at least for now. Longer term, we may do a combination of both.
from opentelemetry-go.
Closing this for now as I believe it makes sense to start with the converted Datadog gRPC plugin (as discussed in last week's SIG meeting), which we should be able to make public soon.
from opentelemetry-go.
Any updates about otgrpc plugin?
from opentelemetry-go.
Why was this issue closed? I think the decision to go through interceptors is a implementation detail but the feature request to create an interceptor/plugin still applies, right?
from opentelemetry-go.
The attached PR #621, addresses tracing but does not implement stats. Is there a roadmap to including the stats plugin in opentelemetry. Is there an Issue that tracks it, or we could re-open this one?
@rghetia @jmacd
from opentelemetry-go.
Related Issues (20)
- Upgrade all use of go.opentelemetry.io/otel/semconv to use v1.25.0
- Document instrument name requirements in metric API
- Declare the priority of options and environments on exporters
- Creating repeated Float64ObservableGauge with the same name, but different callbacks the results in only one callback being used HOT 1
- Flaky test `TestBatchProcessor/DroppedLogs` HOT 2
- The global instance holder should only be set once HOT 9
- resource detect function is not parallel and that can cause issues in custom detectors
- global tracers and meters should be identified also by SchemeURL
- Add otlplogfile exporter
- Tracing overhead and memory usage
- Consider using go module paths for scope name in demos HOT 6
- metric: Add example and documentation for synchronous gauge HOT 2
- metric.WithExplicitBucketBoundaries is not working as expected HOT 4
- Interesting bug potential with `pcommon.Map` HOT 3
- Make it easier to add a resource resource.Detector to the SDKs HOT 3
- Add `Logger.Enabled` SDK processing implementation to the specification
- Add an sdk/internal/x package
- Internal logger.Emit delegate never gets loaded HOT 6
- Data Race: exemplars share rand source without synchronization
- Update .golangci.yml HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-go.